Skip to content

Commit cce7a15

Browse files
authored
Update Makefile targets related to RabbitMQ (#163)
Simplified version of 'stop-rabbitmq-server'. There is no need to figure out the container ID, because `docker stop` supports container names. Container name can now be customised. Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
1 parent 2a72f68 commit cce7a15

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

Makefile

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,14 @@ tests: ## Run all tests and requires a running rabbitmq-server
2323
check:
2424
golangci-lint run ./...
2525

26+
CONTAINER_NAME ?= amqp091-go-rabbitmq
27+
2628
.PHONY: rabbitmq-server
27-
rabbitmq-server:
28-
docker run --detach --rm --name amqp091-go-rabbitmq \
29+
rabbitmq-server: ## Start a RabbitMQ server using Docker. Container name can be customised with CONTAINER_NAME=some-rabbit
30+
docker run --detach --rm --name $(CONTAINER_NAME) \
2931
--publish 5672:5672 --publish 15672:15672 \
3032
--pull always rabbitmq:3-management
3133

3234
.PHONY: stop-rabbitmq-server
33-
stop-rabbitmq-server:
34-
docker stop $$(docker inspect --format='{{.Id}}' amqp091-go-rabbitmq)
35+
stop-rabbitmq-server: ## Stop a RabbitMQ server using Docker. Container name can be customised with CONTAINER_NAME=some-rabbit
36+
docker stop $(CONTAINER_NAME)

0 commit comments

Comments
 (0)