renaming

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>

Author: Gsantomaggio

docs/examples/jms_queue/main.go

@@ -1,6 +1,6 @@
 // RabbitMQ AMQP 1.0 Go Client: https://github.com/rabbitmq/rabbitmq-amqp-go-client
 // RabbitMQ AMQP 1.0 documentation: https://www.rabbitmq.com/docs/amqp
-// This example mirrors getting_started but declares a JMS queue via JmsQueueSpecification
+// This example mirrors getting_started but declares a JMS queue via JMSQueueSpecification
 // (RabbitMQ queue type "jms"). JMS queues are available on Tanzu RabbitMQ 4.x; see:
 // https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-rabbitmq-oci/4-2/tanzu-rabbitmq-oci-image/site-overview.html
 // example path: https://github.com/rabbitmq/rabbitmq-amqp-go-client/tree/main/docs/examples/jms_queue/main.go
@@ -50,7 +50,7 @@ func main() {
 	}
 
 	// Declare a JMS queue (x-queue-type=jms). Optional queue arguments go in Arguments.
-	queueInfo, err := management.DeclareQueue(context.TODO(), &rmq.JmsQueueSpecification{
+	queueInfo, err := management.DeclareQueue(context.TODO(), &rmq.JMSQueueSpecification{
 		Name: queueName,
 	})
 

pkg/rabbitmqamqp/amqp_connection_recovery.go

@@ -120,7 +120,7 @@ func (q *queueRecoveryRecord) toIQueueSpecification() IQueueSpecification {
 			Arguments: q.arguments,
 		}
 	case Jms:
-		return &JmsQueueSpecification{
+		return &JMSQueueSpecification{
 			Name:      q.queueName,
 			Arguments: q.arguments,
 		}

pkg/rabbitmqamqp/amqp_queue_test.go

@@ -247,6 +247,16 @@ var _ = Describe("AMQP Queue test ", func() {
 		Expect(result).To(BeNil())
 	})
 
+	It("should fail if declare a JMS queue in the open source RabbitMQ", func() {
+		queueName := generateName("should fail if declare a JMS queue in the open source RabbitMQ")
+		_, err := management.DeclareQueue(context.TODO(), &JMSQueueSpecification{
+			Name: queueName,
+		})
+		Expect(err).NotTo(BeNil())
+		Expect(err.Error()).To(ContainSubstring("JMSQueueSpecification is only supported on Tanzu RabbitMQ 4.3 or later"))
+
+	})
+
 	// default
 	It("AMQP Declare Queue with DefaultQueueSpecification should succeed", func() {
 		queueName := generateName("AMQP Declare Queue with DefaultQueueSpecification should succeed")

pkg/rabbitmqamqp/entities.go

@@ -22,7 +22,7 @@ const (
 IQueueSpecification represents the specification of a queue.
 The implementation of the queue specification can be used to declare a queue with the specified properties and arguments.
 The client provides multiple implementations of the queue specification for different use cases,
-such as DefaultQueueSpecification, QuorumQueueSpecification, ClassicQueueSpecification, JmsQueueSpecification, and AutoGeneratedQueueSpecification.
+such as DefaultQueueSpecification, QuorumQueueSpecification, ClassicQueueSpecification, JMSQueueSpecification, and AutoGeneratedQueueSpecification.
 The client implementations are helpers that cover the most common use cases, but you can implement your own queue
 specification by implementing the IQueueSpecification interface.
 */
@@ -481,9 +481,9 @@ func (s *StreamQueueSpecification) validate(*featuresAvailable) error {
 }
 
 /*
-JmsQueueSpecification represents the specification of a JMS queue (RabbitMQ queue type "jms").
+JMSQueueSpecification represents the specification of a JMS queue (RabbitMQ queue type "jms").
 */
-type JmsQueueSpecification struct {
+type JMSQueueSpecification struct {
 	Name                 string
 	Arguments            map[string]any
 	AutoExpire           int64
@@ -499,23 +499,23 @@ type JmsQueueSpecification struct {
 	SelectorFields       []string
 }
 
-func (j *JmsQueueSpecification) name() string {
+func (j *JMSQueueSpecification) name() string {
 	return j.Name
 }
 
-func (j *JmsQueueSpecification) isAutoDelete() bool {
+func (j *JMSQueueSpecification) isAutoDelete() bool {
 	return false
 }
 
-func (j *JmsQueueSpecification) isExclusive() bool {
+func (j *JMSQueueSpecification) isExclusive() bool {
 	return false
 }
 
-func (j *JmsQueueSpecification) queueType() TQueueType {
+func (j *JMSQueueSpecification) queueType() TQueueType {
 	return Jms
 }
 
-func (j *JmsQueueSpecification) buildArguments() map[string]any {
+func (j *JMSQueueSpecification) buildArguments() map[string]any {
 	result := j.Arguments
 	if result == nil {
 		result = map[string]any{}
@@ -550,8 +550,15 @@ func (j *JmsQueueSpecification) buildArguments() map[string]any {
 	return result
 }
 
-func (j *JmsQueueSpecification) validate(*featuresAvailable) error {
-	return nil
+func (j *JMSQueueSpecification) validate(f *featuresAvailable) error {
+	// valid only if it is tanzu
+	if f.isTanzu && f.is43rMore {
+		return nil
+	}
+	// error not support for open source RabbitMQ
+
+	return fmt.Errorf("JMSQueueSpecification is only supported on Tanzu RabbitMQ 4.3 or later")
+
 }
 
 // durationToMaxAge converts a time.Duration to the RabbitMQ stream x-max-age string format.

pkg/rabbitmqamqp/entities_test.go

@@ -86,9 +86,9 @@ var _ = Describe("Entities", func() {
 		})
 	})
 
-	Describe("JmsQueueSpecification", func() {
+	Describe("JMSQueueSpecification", func() {
 		It("should always set x-queue-type to jms and fixed durability flags", func() {
-			spec := &JmsQueueSpecification{Name: "my-jms-queue"}
+			spec := &JMSQueueSpecification{Name: "my-jms-queue"}
 			Expect(spec.isAutoDelete()).To(BeFalse())
 			Expect(spec.isExclusive()).To(BeFalse())
 			Expect(spec.queueType()).To(Equal(Jms))
@@ -97,7 +97,7 @@ var _ = Describe("Entities", func() {
 		})
 
 		It("should merge optional arguments", func() {
-			spec := &JmsQueueSpecification{
+			spec := &JMSQueueSpecification{
 				Name:      "my-jms-queue",
 				Arguments: map[string]any{"x-max-length-bytes": int64(1000)},
 			}