few improvements

Author: DanielePalaia

rabbitmq_amqp_python_client/connection.py

@@ -278,6 +278,7 @@ def consumer(
 
     def _on_disconnection(self) -> None:
 
+        logger.debug("_on_disconnection: disconnection detected")
         if self in self._connections:
             self._connections.remove(self)
 
@@ -286,6 +287,7 @@ def _on_disconnection(self) -> None:
 
         for attempt in range(self._recovery_configuration.MaxReconnectAttempts):  # type: ignore
 
+            logger.debug("attempting a reconnection")
             jitter = timedelta(milliseconds=random.randint(0, 500))
             delay = base_delay + jitter
 
@@ -318,16 +320,24 @@ def _on_disconnection(self) -> None:
 
             except ConnectionException as e:
                 base_delay *= 2
-                logger.error(
+                logger.debug(
                     "Reconnection attempt failed",
                     "attempt",
                     attempt,
                     "error",
                     str(e),
                 )
-                continue
+                # maximum attempts reached without establishing a connection
+                if attempt == self._recovery_configuration.MaxReconnectAttempts - 1:  # type: ignore
+                    logger.debug("Not able to reconnect")
+                    raise ConnectionException
+                else:
+                    continue
 
-            break
+            # connection established
+            else:
+                logger.debug("reconnected successful")
+                return
 
     @property
     def active_producers(self) -> int:

rabbitmq_amqp_python_client/entities.py

@@ -231,5 +231,5 @@ class RecoveryConfiguration:
     """
 
     active_recovery: bool = True
-    back_off_reconnect_interval: timedelta = timedelta(0.5)
+    back_off_reconnect_interval: timedelta = timedelta(seconds=5)
     MaxReconnectAttempts: int = 5

rabbitmq_amqp_python_client/qpid/proton/_tracing.py

@@ -32,10 +32,8 @@
 
 import proton
 from proton import Sender as ProtonSender
-from proton.handlers import \
-    IncomingMessageHandler as ProtonIncomingMessageHandler
-from proton.handlers import \
-    OutgoingMessageHandler as ProtonOutgoingMessageHandler
+from proton.handlers import IncomingMessageHandler as ProtonIncomingMessageHandler
+from proton.handlers import OutgoingMessageHandler as ProtonOutgoingMessageHandler
 
 _tracer = None
 _trace_key = proton.symbol("x-opt-qpid-tracestate")

rabbitmq_amqp_python_client/qpid/proton/_transport.py

@@ -139,8 +139,7 @@
 
 if TYPE_CHECKING:
     from ._condition import Condition
-    from ._endpoints import \
-        Connection  # would produce circular import
+    from ._endpoints import Connection  # would produce circular import
 
 
 class TraceAdapter: