Skip to content

Commit cf3a559

Browse files
committed
Delete test access_failure
This test flakes in CI as described in #12413 (comment) The test case fails with ``` Node: rabbit_shard2@localhost Case: amqp_system_SUITE:access_failure Reason: {error,{{badmatch,{error,134, "Unhandled exception. System.Exception: expected exception not received at Program.Test.accessFailure(String uri) in /home/runner/work/rabbitmq-server/rabbitmq-server/deps/rabbit/test/amqp_system_SUITE_data/fsharp-tests/Program.fs:line 477 at Program.main(String[] argv) in /home/runner/work/rabbitmq-server/rabbitmq-server/deps/rabbit/test/amqp_system_SUITE_data/fsharp-tests/Program.fs:line 509\n"}}, [{amqp_system_SUITE,run_dotnet_test,2, [{file,"amqp_system_SUITE.erl"}, {line,257}]}, ``` However, RabbitMQ closes the session as expected due to the missing read permissions to the queue as shown in the RabbitMQ logs: ``` [debug] <0.1321.0> Asked to create a new user 'access_failure', password length in bytes: 24 [info] <0.1321.0> Created user 'access_failure' [debug] <0.1324.0> Asked to set permissions for user 'access_failure' in virtual host '/' to '.*', '^banana.*', '^banana.*' [info] <0.1324.0> Successfully set permissions for user 'access_failure' in virtual host '/' to '.*', '^banana.*', '^banana.*' [info] <0.1333.0> accepting AMQP connection 127.0.0.1:36248 -> 127.0.0.1:25000 [debug] <0.1333.0> User 'access_failure' authenticated successfully by backend rabbit_auth_backend_internal [info] <0.1333.0> Connection from AMQP 1.0 container 'AMQPNetLite-101d7d51': user 'access_failure' authenticated using SASL mechanism PLAIN and granted access to vhost '/' [debug] <0.1333.0> AMQP 1.0 connection.open frame: hostname = 127.0.0.1, extracted vhost = /, idle-time-out = undefined [debug] <0.1333.0> AMQP 1.0 created session process <0.1338.0> for channel number 0 [warning] <0.1338.0> Closing session for connection <0.1333.0>: {'v1_0.error', [warning] <0.1338.0> {symbol, [warning] <0.1338.0> <<"amqp:unauthorized-access">>}, [warning] <0.1338.0> {utf8, [warning] <0.1338.0> <<"read access to queue 'test' in vhost '/' refused for user 'access_failure'">>}, [warning] <0.1338.0> undefined} [debug] <0.1333.0> AMQP 1.0 closed session process <0.1338.0> with channel number 0 [warning] <0.1333.0> closing AMQP connection <0.1333.0> (127.0.0.1:36248 -> 127.0.0.1:25000, duration: '269ms'): [warning] <0.1333.0> client unexpectedly closed TCP connection ``` ``` let receiver = ReceiverLink(ac.Session, "test-receiver", src) ``` uses a null constructur for the onAttached callback. ReceiverLink doesn't seem to block. Given that the exact same authorization error is already tested in test case attach_source_queue of amqp_auth_SUITE, it's safe to delete this F# test. (cherry picked from commit b1169d0)
1 parent 5bd0bad commit cf3a559

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

deps/rabbit/test/amqp_system_SUITE.erl

-13
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ groups() ->
3838
routing,
3939
invalid_routes,
4040
auth_failure,
41-
access_failure,
4241
access_failure_not_allowed,
4342
access_failure_send,
4443
streams
@@ -212,18 +211,6 @@ invalid_routes(Config) ->
212211
auth_failure(Config) ->
213212
run(Config, [ {dotnet, "auth_failure"} ]).
214213

215-
access_failure(Config) ->
216-
User = atom_to_binary(?FUNCTION_NAME),
217-
ok = rabbit_ct_broker_helpers:add_user(Config, User, <<"boo">>),
218-
ok = rabbit_ct_broker_helpers:set_permissions(Config, User, <<"/">>,
219-
<<".*">>, %% configure
220-
<<"^banana.*">>, %% write
221-
<<"^banana.*">> %% read
222-
),
223-
run(Config, [ {dotnet, "access_failure"} ]),
224-
ok = rabbit_ct_broker_helpers:delete_user(Config, User).
225-
226-
227214
access_failure_not_allowed(Config) ->
228215
User = atom_to_binary(?FUNCTION_NAME),
229216
ok = rabbit_ct_broker_helpers:add_user(Config, User, <<"boo">>),

deps/rabbit/test/amqp_system_SUITE_data/fsharp-tests/Program.fs

-17
Original file line numberDiff line numberDiff line change
@@ -466,20 +466,6 @@ module Test =
466466
printfn "Exception %A" ex
467467
()
468468

469-
let accessFailure uri =
470-
try
471-
let u = Uri uri
472-
let uri = sprintf "amqp://access_failure:boo@%s:%i" u.Host u.Port
473-
use ac = connect uri
474-
let src = "/queues/test"
475-
let receiver = ReceiverLink(ac.Session, "test-receiver", src)
476-
receiver.Close()
477-
failwith "expected exception not received"
478-
with
479-
| :? Amqp.AmqpException as ex ->
480-
printfn "Exception %A" ex
481-
()
482-
483469
let accessFailureNotAllowed uri =
484470
try
485471
let u = Uri uri
@@ -505,9 +491,6 @@ let main argv =
505491
| [AsLower "auth_failure"; uri] ->
506492
authFailure uri
507493
0
508-
| [AsLower "access_failure"; uri] ->
509-
accessFailure uri
510-
0
511494
| [AsLower "access_failure_not_allowed"; uri] ->
512495
accessFailureNotAllowed uri
513496
0

0 commit comments

Comments
 (0)