Add case to concurrent queue delete #16765
Replies: 2 comments
-
|
@25schmekles I'm afraid we won't rush to implement a suggestion with a two sentence description and no details on how to reproduce a behavior and why it is worth our small team's time. |
Beta Was this translation helpful? Give feedback.
-
|
And rightly so. Let me elaborate a little. As I understand it, in this situation the queue is being successfully removed. So, it seems like Admittedly, this is a low priority/impact issue. Steps to ReproduceThis is a bit of a race condition and tends to surfaces during automated removal of a vhost.
FixAdd a clause in
I'm happy to open a PR if this seems reasonable. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
If
ra:delete_cluster/2calls overlap the Ra cluster is found mid-shutdown and a{error, {shutdown, delete}}is raised.During a concurrent queue or vhost delete, if there is an overlap, this case can miss
{error, {shutdown, delete}}and crash even though the queue is being successfully deleted.rabbitmq-server/deps/rabbit/src/rabbit_quorum_queue.erl
Line 1099 in b8a3ae5
Beta Was this translation helpful? Give feedback.
All reactions