Merge pull request #145 from lostapathy/unicode_sizes

mpalmer · web-flow · commit a7eb3f420157 · 2017-12-08T16:27:04.000+11:00
Correct Content-Length bug of Rack::NotFound
diff --git a/lib/rack/contrib/not_found.rb b/lib/rack/contrib/not_found.rb
@@ -19,7 +19,7 @@ def initialize(path = nil, content_type = 'text/html')
       else
         @content = F.read(path)
       end
-      @length = @content.size.to_s
+      @length = @content.bytesize.to_s
 
       @content_type = content_type
     end
diff --git a/test/spec_rack_not_found.rb b/test/spec_rack_not_found.rb
@@ -1,6 +1,7 @@
 require 'minitest/autorun'
 require 'rack/mock'
 require 'rack/contrib/not_found'
+require 'tempfile'
 
 describe "Rack::NotFound" do
 
@@ -40,4 +41,18 @@
     response.status.must_equal(404)
   end
 
+  specify "should return correct size" do
+    Tempfile.open('test') do |f|
+      f.write '<!DOCTYPE html>'
+      f.write '<meta charset=utf-8>'
+      f.write '☃ snowman'
+      f.close
+      app = Rack::Builder.new do
+        use Rack::Lint
+        run Rack::NotFound.new(f.path)
+      end
+      response = Rack::MockRequest.new(app).get('/')
+      response.headers['Content-Length'].must_equal('46')
+    end
+  end
 end
