chore: install pre_commit as a dev requirement (#886)

* chore: install pre_commit as a dev requirement

* chore: pre_commit hook pkg updates and dev requirements

* fix: cleanup old lock file

Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

* fix: remove duplicate yaml

Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

* fix: yamllint indentation add notifications

Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

---------

Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
Co-authored-by: Kevin Carter <kevin.carter@rackspace.com>

Author: rackerchris

.ansible/.lock

@@ -0,0 +1,37 @@
+on: pull_request_target
+
+jobs:
+  welcome:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/github-script@v7
+        with:
+          script: |
+            // Get a list of all issues created by the PR opener
+            // See: https://octokit.github.io/rest.js/#pagination
+            const creator = context.payload.sender.login
+            const opts = github.rest.issues.listForRepo.endpoint.merge({
+              ...context.issue,
+              creator,
+              state: 'all'
+            })
+            const issues = await github.paginate(opts)
+
+            for (const issue of issues) {
+              if (issue.number === context.issue.number) {
+                continue
+              }
+
+              if (issue.pull_request) {
+                return // Creator is already a contributor.
+              }
+            }
+
+            await github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: `**Welcome**, new contributor!
+
+                Please make sure you've read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨`
+            })

.github/workflows/new-contributor.yaml

@@ -1,6 +1,7 @@
 name: Run pull-request syntax workflows
 on:
   - pull_request
+
 jobs:
   pre_commit:
     runs-on: ubuntu-latest
@@ -19,21 +20,8 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@v23.1
       - name: Run Check
-        uses: pre-commit/action@v3.0.0
+        uses: pre-commit/action@v3.0.1
         with:
           extra_args: >-
             --files ${{ steps.changed-files.outputs.all_changed_files }}
             --hook-stage manual
-
-      - name: Checks failed, notification
-        if: failure()
-        run: |
-          echo "Tests Failed"
-          echo "Run the following command to identify issues"
-          echo "pre-commit run --files ${{ steps.changed-files.outputs.all_changed_files }}"
-      - name: Upload log artifacts on failure
-        if: failure()
-        uses: actions/upload-artifact@v4
-        with:
-          name: pre-commit-py${{ matrix.python-version }}
-          path: /home/runner/.cache/pre-commit/pre-commit.log

.github/workflows/pre-commit.yaml

@@ -19,7 +19,7 @@ repos:
         stages:
           - commit-msg
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.5.0
+    rev: v5.0.0
     hooks:
       - id: end-of-file-fixer
         stages:
@@ -51,13 +51,13 @@ repos:
           - "--unsafe"
       - id: debug-statements
   - repo: https://github.com/psf/black
-    rev: 24.1.1
+    rev: 25.1.0
     hooks:
       - id: black
         stages:
           - manual
   - repo: https://github.com/adrienverge/yamllint.git
-    rev: v1.29.0
+    rev: v1.35.1
     hooks:
       - id: yamllint
         stages:
@@ -67,7 +67,7 @@ repos:
             -d {extends: default, rules: {line-length: disable},
             ignore: [submodules/]}
   - repo: https://github.com/ansible-community/ansible-lint
-    rev: v6.22.2
+    rev: v24.9.2
     hooks:
       - id: ansible-lint
         stages:

.pre-commit-config.yaml

@@ -75,8 +75,6 @@ conf:
       auth_type: password
       auth_version: v3
       memcache_security_strategy: ENCRYPT
-      service_token_roles: service
-      service_token_roles_required: true
       service_type: load-balancer
       valid_interfaces: internal
     neutron:
@@ -178,20 +176,20 @@ pod:
       init_container: null
       octavia_api:
         volumeMounts:
-        - name: pod-run-octavia
-          mountPath: /var/run/octavia
+          - name: pod-run-octavia
+            mountPath: /var/run/octavia
         volumes:
-        - name: pod-run-octavia
-          emptyDir: {}
+          - name: pod-run-octavia
+            emptyDir: {}
     octavia_worker:
       init_container: null
       octavia_worker:
         volumeMounts:
-        - name: pod-run-octavia
-          mountPath: /var/run/octavia
+          - name: pod-run-octavia
+            mountPath: /var/run/octavia
         volumes:
-        - name: pod-run-octavia
-          emptyDir: {}
+          - name: pod-run-octavia
+            emptyDir: {}
     octavia_driver_agent:
       init_container: null
       octavia_bootstrap:

base-helm-configs/octavia/octavia-helm-overrides.yaml

@@ -22,4 +22,5 @@ subprocess-tee==0.4.1
 tomli==2.0.1
 typing-extensions==4.9.0
 wcmatch==8.5
-yamllint==1.34.0
+yamllint==1.35.1
+pre_commit==4.1.0