Have port_bios_name out-of-band inspection hook set the port name

We were leaving these NULL but actually it is better to have the port
name set to something meaningful.

Author: stevekeay

python/ironic-understack/ironic_understack/port_bios_name_hook.py

@@ -52,6 +52,17 @@ def __call__(self, task, inventory, plugin_data):
                 baremetal_port.pxe_enabled = required_pxe
                 baremetal_port.save()
 
+            if required_bios_name:
+                required_port_name = task.node.name + ":" + required_bios_name
+                if baremetal_port.name != required_port_name:
+                    LOG.info(
+                        "Port %s changing name from %s to %s",
+                        mac,
+                        baremetal_port.name,
+                        required_port_name,
+                    )
+                    baremetal_port.name = required_port_name
+
 
 def _pxe_interface_name(inspected_interfaces: list[dict]) -> str:
     """Use a heuristic to determine our default interface for PXE."""

python/ironic-understack/ironic_understack/tests/test_port_bios_name_hook.py

@@ -19,13 +19,15 @@ def test_adding_bios_name(mocker, caplog):
     node_uuid = uuidutils.generate_uuid()
     mock_context = mocker.Mock()
     mock_node = mocker.Mock(id=1234)
+    mock_node.name = "Dell-CR1MB0"
     mock_task = mocker.Mock(node=mock_node, context=mock_context)
     mock_port = mocker.Mock(
         uuid=uuidutils.generate_uuid(),
         node_id=node_uuid,
         address="11:11:11:11:11:11",
         extra={},
     )
+    mock_port.name = "some-arbitrary-name"
 
     mocker.patch(
         "ironic_understack.port_bios_name_hook.ironic_ports_for_node",
@@ -35,6 +37,7 @@ def test_adding_bios_name(mocker, caplog):
     PortBiosNameHook().__call__(mock_task, _INVENTORY, {})
 
     assert mock_port.extra == {"bios_name": "NIC.Integrated.1-1"}
+    assert mock_port.name == "Dell-CR1MB0:NIC.Integrated.1-1"
     mock_port.save.assert_called()
 
 
@@ -44,13 +47,15 @@ def test_removing_bios_name(mocker, caplog):
     node_uuid = uuidutils.generate_uuid()
     mock_context = mocker.Mock()
     mock_node = mocker.Mock(id=1234)
+    mock_node.name = "Dell-CR1MB0"
     mock_task = mocker.Mock(node=mock_node, context=mock_context)
     mock_port = mocker.Mock(
         uuid=uuidutils.generate_uuid(),
         node_id=node_uuid,
         address="33:33:33:33:33:33",
         extra={"bios_name": "old_name_no_longer_valid"},
     )
+    mock_port.name = "original-name"
 
     mocker.patch(
         "ironic_understack.port_bios_name_hook.ironic_ports_for_node",
@@ -59,5 +64,6 @@ def test_removing_bios_name(mocker, caplog):
 
     PortBiosNameHook().__call__(mock_task, _INVENTORY, {})
 
+    assert mock_port.name == "original-name"
     assert "bios_name" not in mock_port.extra
     mock_port.save.assert_called()