Merge pull request #1642 from rackerlabs/correct-manufacturer-nautobot

fix(nautobot-device-sync): PUC-1465: normalise HP manufacturer to HPE for device type lookup

Author: nicholaskuechler

python/understack-workflows/tests/test_nautobot_device_sync.py

@@ -47,7 +47,7 @@ def test_normalise_dell_mixed_case(self):
         assert _normalise_manufacturer("Dell Inc.") == "Dell"
 
     def test_normalise_hp(self):
-        assert _normalise_manufacturer("HP") == "HP"
+        assert _normalise_manufacturer("HP") == "HPE"
 
     def test_unsupported_manufacturer_raises(self):
         with pytest.raises(ValueError, match="not supported"):
@@ -182,15 +182,15 @@ def test_manufacturer_fallback(self, device_info):
         inventory = {
             "inventory": {
                 "system_vendor": {
-                    "manufacturer": "HP",  # Different
+                    "manufacturer": "HP",  # Different - normalised to HPE
                 }
             }
         }
 
         _populate_from_inventory(device_info, inventory)
 
-        # Inventory always sets manufacturer
-        assert device_info.manufacturer == "HP"
+        # Inventory always sets manufacturer (HP normalised to HPE)
+        assert device_info.manufacturer == "HPE"
 
 
 class TestGenerateDeviceName:

python/understack-workflows/understack_workflows/oslo_event/nautobot_device_sync.py

@@ -81,7 +81,7 @@ def _normalise_manufacturer(name: str) -> str:
     if "DELL" in name.upper():
         return "Dell"
     elif "HP" in name.upper():
-        return "HP"
+        return "HPE"
     raise ValueError(f"Server manufacturer {name} not supported")