Fix UB cast in container_of macro ##crash

radare · trufae · commit 620f33d0cc40 · 2026-02-12T18:29:51.000+01:00
diff --git a/libr/include/r_types.h b/libr/include/r_types.h
@@ -750,7 +750,7 @@ static inline void r_run_call10(void *fcn, void *arg1, void *arg2, void *arg3, v
 }
 
 #ifndef container_of
-#define container_of(ptr, type, member) (ptr? ((type *)((char *)(ptr) - r_offsetof(type, member))): NULL)
+#define container_of(ptr, type, member) ((ptr)? ((type *)(void *)((char *)(ptr) - r_offsetof(type, member))): NULL)
 #endif
 
 #endif // R2_TYPES_H

Original file line number	Diff line number	Diff line change
`@@ -750,7 +750,7 @@ static inline void r_run_call10(void fcn, void arg1, void arg2, void arg3, v`
`750`	`750`	`}`
`751`	`751`
`752`	`752`	`#ifndef container_of`
`753`		`-#define container_of(ptr, type, member) (ptr? ((type )((char )(ptr) - r_offsetof(type, member))): NULL)`
	`753`	`+#define container_of(ptr, type, member) ((ptr)? ((type )(void )((char *)(ptr) - r_offsetof(type, member))): NULL)`
`754`	`754`	`#endif`
`755`	`755`
`756`	`756`	`#endif // R2_TYPES_H`