Remove unnecessary xref sorting on every query ##analysis

claude · radare · commit ff08e8b55b79 · 2026-04-08T13:16:56.000+02:00
https://claude.ai/code/session_015tU8A23whE5bgreK4UoDNM
diff --git a/libr/anal/xrefs.c b/libr/anal/xrefs.c
@@ -326,7 +326,6 @@ R_API RVecAnalRef *r_anal_refs_get(RAnal *anal, ut64 from) {
 		return NULL;
 	}
 
-	RVecAnalRef_sort (anal_refs, compare_ref); // XXX not needed?
 	return anal_refs;
 }
 
@@ -339,7 +338,6 @@ R_API RVecAnalRef *r_anal_xrefs_get(RAnal *anal, ut64 to) {
 		return NULL;
 	}
 
-	RVecAnalRef_sort (anal_refs, compare_ref); // XXX not needed?
 	return anal_refs;
 }
 
@@ -352,7 +350,6 @@ R_API RVecAnalRef *r_anal_xrefs_get_from(RAnal *anal, ut64 to) {
 		return NULL;
 	}
 
-	RVecAnalRef_sort (anal_refs, compare_ref); // XXX not needed?
 	return anal_refs;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,6 @@ R_API RVecAnalRef r_anal_refs_get(RAnal anal, ut64 from) {`
`326`	`326`	`return NULL;`
`327`	`327`	`}`
`328`	`328`
`329`		`- RVecAnalRef_sort (anal_refs, compare_ref); // XXX not needed?`
`330`	`329`	`return anal_refs;`
`331`	`330`	`}`
`332`	`331`
`@@ -339,7 +338,6 @@ R_API RVecAnalRef r_anal_xrefs_get(RAnal anal, ut64 to) {`
`339`	`338`	`return NULL;`
`340`	`339`	`}`
`341`	`340`
`342`		`- RVecAnalRef_sort (anal_refs, compare_ref); // XXX not needed?`
`343`	`341`	`return anal_refs;`
`344`	`342`	`}`
`345`	`343`
`@@ -352,7 +350,6 @@ R_API RVecAnalRef r_anal_xrefs_get_from(RAnal anal, ut64 to) {`
`352`	`350`	`return NULL;`
`353`	`351`	`}`
`354`	`352`
`355`		`- RVecAnalRef_sort (anal_refs, compare_ref); // XXX not needed?`
`356`	`353`	`return anal_refs;`
`357`	`354`	`}`
`358`	`355`