love a song on last.fm when upvoting on Google Music

[chrismou]

Ability (controlled by a setting) to submit a song as a "loved track" to last.fm when you upvote it on Google Music.

Would be good to decide if we actually want this. On one hand this is really useful for last.fm users (I use it myself all the time!) but on the other hand, our current implementation submits whatever song is currently playing regardless of which song you thumb up.

This is a bit confusing, and I'm not sure if it can be worked around as gmusic.js provides the current song, but upvoting other songs is an internal call to the Google Music API. If this is the case, we need to decide whether to just continue doing it the way we do "because it's always been like that" (and maybe add a note of the limitation on the settings page), or just abandon it altogether because it doesn't/won't work as expected.

[matthewdias]

If it can't be worked around, I would suggest just adding a separate love button to the playback controls and then miniplayer.

[jacobwgillespie]

Seems like at a minimum we could "love" tracks that are thumbs-upped when they are currently playing, as I think gmusic.js only responds with a rating event when it is liked from the current player (so, it ignores thumbs ups in playlists, etc.). It'd be nice to expand gmusic.js to support detection of any thumbs up along with details about what was rated at some point, but that's another task.

[chrismou]

I wouldn't be adverse to adding a separate last.fm "love" button, as it least it'd be obvious what it's doing when you click it.

I'd rather keep the 2 integrated as it is with current Radiant, but it's just so confusing - at points I was trying to love a track, and instead it was un-loving a track I'd loved earlier! That's not really ideal

Background is here: radiant-player/radiant-player-mac#355