Commit bb6443b
fix(e2e): give the desktop run room on a Windows runner
Ubuntu passed the whole spec in 2m33s. Windows was still merging when the
180-second wait expired, having got as far as "Filtering images: kept 13
of 18" and stopped there. Nothing was wrong: the WebAssembly build is
single-threaded on purpose and a GitHub Windows runner is two slow cores.
Raised to ten minutes, and mocha's own timeout past that so a slow run
fails with the app's last reported state rather than mocha killing the
test first and reporting only that time ran out.
Also stopped the state report crying wolf. It flagged any `role="dialog"`
as blocking the run, but the progress modal is one -- so it announced
"BLOCKED-BY-DIALOG" on every healthy run, which is worse than saying
nothing, because the one time it matters nobody believes it. It now looks
for a dialog that actually offers a decision.
Worth recording that the diagnostic earned its keep on its first CI run:
the failure named the last four pipeline steps and their timestamps, so
"stalled after filtering" was legible from the log without reproducing
anything.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent a65645c commit bb6443b
2 files changed
Lines changed: 22 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
251 | | - | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
252 | 256 | | |
253 | 257 | | |
254 | 258 | | |
| |||
275 | 279 | | |
276 | 280 | | |
277 | 281 | | |
278 | | - | |
279 | | - | |
280 | | - | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
281 | 295 | | |
282 | 296 | | |
283 | 297 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
58 | 61 | | |
59 | 62 | | |
60 | 63 | | |
| |||
0 commit comments