@shabbir137 recently pointed out that the flat-sky simulation pipeline (called by cora-makesky from the command line) uses several different definitions of cosmological quantities (mean brightness temperature, growth factor, growth rate) than the full-sky pipeline, and this can lead to issues when comparing the two calculations (and also when simply reading the code and trying to associated specific definitions to where they are used). Furthermore, several of the flat-sky definitions use unnecessary approximations (e.g. using the matter-only growth rate in
|
def growth_factor(self, z): |
).
While not terribly urgent, it would be good to reorganize the code to ensure that consistent definitions are used everywhere in the code, and in the process use more accurate definitions in the flat-sky computation. We'd probably want to keep previous definitions somewhere and add an option to use them for legacy compatibility.
@shabbir137 recently pointed out that the flat-sky simulation pipeline (called by
cora-makeskyfrom the command line) uses several different definitions of cosmological quantities (mean brightness temperature, growth factor, growth rate) than the full-sky pipeline, and this can lead to issues when comparing the two calculations (and also when simply reading the code and trying to associated specific definitions to where they are used). Furthermore, several of the flat-sky definitions use unnecessary approximations (e.g. using the matter-only growth rate incora/cora/signal/corr.py
Line 468 in 07a2f3e
While not terribly urgent, it would be good to reorganize the code to ensure that consistent definitions are used everywhere in the code, and in the process use more accurate definitions in the flat-sky computation. We'd probably want to keep previous definitions somewhere and add an option to use them for legacy compatibility.