Update golangci-lint (#11)

Update golangci-lint

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Antoine Gelloz <[email protected]>

Author: renovate[bot]

.github/workflows/qa.yml

@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     env:
       # renovate: datasource=github-releases depName=radiofrance/lint-config
-      LINT_CONFIG_VERSION: v1.1.0
+      LINT_CONFIG_VERSION: v1.1.1
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
@@ -32,4 +32,4 @@ jobs:
       - uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd # v7.0.0
         with:
           # renovate: datasource=github-releases depName=golangci/golangci-lint
-          version: v2.0.2
+          version: v2.1.5

Makefile

@@ -19,7 +19,7 @@ help: ## Display this message
 qa: lint ## Run all Q.A.
 
 # renovate: datasource=github-tags depName=radiofrance/lint-config
-LINT_CONFIG_VERSION = v1.1.0
+LINT_CONFIG_VERSION = v1.1.1
 
 lint: ## Lint source code
 	curl -o .golangci.yml https://raw.githubusercontent.com/radiofrance/lint-config/$(LINT_CONFIG_VERSION)/.golangci.yml

registry.go

@@ -43,37 +43,6 @@ func (r *Registry) RegistryStr() string {
 	return strings.Split(r.URL, "/")[0]
 }
 
-// initAuthenticator returns an authn.Authenticator used by the docker golang library
-// to authenticate with a docker registry
-//
-// We generate the authn.Authenticator once, otherwise the resolver will try to resolve
-// the gcloud credentials before each api call. We check for the presence of an environment
-// variable GCR_JSON_KEY_PATH. If present, we use it, otherwise, we default to the default
-// keychain mechanism.
-func (r *Registry) initAuthenticator() error {
-	gcrJSONKeyPath := os.Getenv(EnvGcrJSONKeyPath)
-	if gcrJSONKeyPath != "" {
-		key, err := os.ReadFile(gcrJSONKeyPath) //nolint:gosec
-		if err != nil {
-			return fmt.Errorf("failed to resolve authenticator using gcr json key at %s: %w", gcrJSONKeyPath, err)
-		}
-		r.authenticator = &authn.Basic{
-			Username: "_json_key",
-			Password: string(key),
-		}
-
-		return nil
-	}
-
-	var err error
-	r.authenticator, err = authn.DefaultKeychain.Resolve(r)
-	if err != nil {
-		return fmt.Errorf("failed to resolve authenticator using default keychain: %w", err)
-	}
-
-	return nil
-}
-
 // Head is a wrapper to the remote.Head method.
 func (r *Registry) Head(imageRef string) (*v1.Descriptor, error) {
 	ref, err := name.ParseReference(imageRef)
@@ -152,3 +121,34 @@ func (r *Registry) Retag(existingRef, toCreateRef string) error {
 
 	return nil
 }
+
+// initAuthenticator returns an authn.Authenticator used by the docker golang library
+// to authenticate with a docker registry
+//
+// We generate the authn.Authenticator once, otherwise the resolver will try to resolve
+// the gcloud credentials before each api call. We check for the presence of an environment
+// variable GCR_JSON_KEY_PATH. If present, we use it, otherwise, we default to the default
+// keychain mechanism.
+func (r *Registry) initAuthenticator() error {
+	gcrJSONKeyPath := os.Getenv(EnvGcrJSONKeyPath)
+	if gcrJSONKeyPath != "" {
+		key, err := os.ReadFile(gcrJSONKeyPath) //nolint:gosec
+		if err != nil {
+			return fmt.Errorf("failed to resolve authenticator using gcr json key at %s: %w", gcrJSONKeyPath, err)
+		}
+		r.authenticator = &authn.Basic{
+			Username: "_json_key",
+			Password: string(key),
+		}
+
+		return nil
+	}
+
+	var err error
+	r.authenticator, err = authn.DefaultKeychain.Resolve(r)
+	if err != nil {
+		return fmt.Errorf("failed to resolve authenticator using default keychain: %w", err)
+	}
+
+	return nil
+}