refactor tests

Author: radiovisual

test/api.js

@@ -3,9 +3,12 @@ import path from 'path';
 import wait from 'wait-p';
 import pify from 'pify';
 import test from 'ava';
+import tempfile from 'tempfile';
+import rimraf from 'rimraf';
 import Timecard from '../dist/index.js';
 
 const fixtures = path.resolve('test/fixtures');
+const temppath = tempfile('.json');
 
 test('expose a constructor', t => {
 	t.is(typeof Timecard, 'function');
@@ -63,7 +66,11 @@ test('allow print before clockout', async t => {
 });
 
 test('records total seconds', async t => {
-	const timecard = new Timecard();
+	// we have to create a timecard even though we we aren't using the physical
+	// file in these tests because the clockin and clockout commands require a 
+	// timecard file before executing.
+	const timecard = new Timecard({prompt: false, filepath: temppath});
+	await timecard.create();
 
 	const fixture = path.join(fixtures, 'timecard.json');
 	const data = await pify(fs.readFile)(fixture, 'utf8');
@@ -75,3 +82,7 @@ test('records total seconds', async t => {
 
 	t.true(timecard.totalSeconds >= 3600 + 60 + 1 + 3);
 });
+
+test.after.always('cleanup tempfile', () => {
+	rimraf.sync(temppath);
+});

test/clockin.js

@@ -3,26 +3,38 @@ import path from 'path';
 import pify from 'pify';
 import test from 'ava';
 import tempfile from 'tempfile';
+import rimraf from 'rimraf';
 import Timecard from '../dist/';
 
 const fixtures = path.resolve('test/fixtures');
 
+const tempfiles = [];
+
+test.beforeEach('cleanup tempfile', async t => {
+		// Create a blank timecard on the disk so that the operations
+		// that require a timecard file can find one.
+		const temppath = tempfile('.json');
+		tempfiles.push(temppath);
+		t.context.timecard = new Timecard({prompt: false, filepath: temppath});
+		await t.context.timecard.create();
+});
+
 test('clockin', async t => {
-	const timecard = new Timecard();
+	const timecard = t.context.timecard;
 	timecard.clockin().then(result => {
 		t.true(result.search('clocked in') > -1);
 	});
 });
 
 test('clockin with message', async t => {
-	const timecard = new Timecard();
+	const timecard = t.context.timecard;
 	await timecard.clockin('yo dude');
 
   t.is(timecard.shifts['1'].messages[0], 'yo dude');
 });
 
 test('prevent clockin if clockout pending', async t => {
-	const timecard = new Timecard();
+	const timecard = t.context.timecard;
 
 	const fixture = path.join(fixtures, 'pendingClockout.json');
 	const data = await pify(fs.readFile)(fixture, 'utf8');
@@ -49,3 +61,10 @@ test('cant run clockin operations on illegal locations', async t => {
 		t.true(err.search('You must create a timecard before clocking in') > -1);
 	});
 });
+
+test.after.always('cleanup tempfiles', () => {
+	tempfiles.forEach(path => {
+		console.log('deleting temppath:', path);
+		rimraf.sync(path);
+	});
+});

test/clockout.js

@@ -3,13 +3,24 @@ import path from 'path';
 import pify from 'pify';
 import test from 'ava';
 import tempfile from 'tempfile';
+import rimraf from 'rimraf';
 import Timecard from '../dist/';
 
 const fixtures = path.resolve('test/fixtures');
 
-test('clockout', async t => {
-	const timecard = new Timecard();
+const tempfiles = [];
+
+test.beforeEach('cleanup tempfile', async t => {
+		// Create a blank timecard on the disk so that the operations
+		// that require a timecard file can find one.
+		const temppath = tempfile('.json');
+		tempfiles.push(temppath);
+		t.context.timecard = new Timecard({prompt: false, filepath: temppath});
+		await t.context.timecard.create();
+});
 
+test('clockout', async t => {
+	const timecard = t.context.timecard;
 	const fixture = path.join(fixtures, 'pendingClockout.json');
 	const data = await pify(fs.readFile)(fixture, 'utf8');
 	await timecard.load(data);
@@ -19,7 +30,7 @@ test('clockout', async t => {
 });
 
 test('clockout with message', async t => {
-	const timecard = new Timecard();
+	const timecard = t.context.timecard;
 	await timecard.clockin('foo');
 	await timecard.clockout('bar');
 
@@ -28,8 +39,7 @@ test('clockout with message', async t => {
 });
 
 test('prevent clockout before clockin', async t => {
-	const timecard = new Timecard();
-
+	const timecard = t.context.timecard;
 	const fixture = path.join(fixtures, 'blank.json');
 	const data = await pify(fs.readFile)(fixture, 'utf8');
 	await timecard.load(data);
@@ -48,8 +58,7 @@ test('report error if attempt to clockout with no timecard', t => {
 });
 
 test('prevent clockout if clockin pending', async t => {
-  const timecard = new Timecard();
-
+	const timecard = t.context.timecard;
   const fixture = path.join(fixtures, 'blank.json');
 	const data = await pify(fs.readFile)(fixture, 'utf8');
 	await timecard.load(data);
@@ -67,3 +76,10 @@ test('cant run clockout operations on illegal locations', async t => {
 		t.true(err.search('You must create a timecard before clocking out') > -1);
 	});
 });
+
+test.after.always('cleanup tempfiles', () => {
+	tempfiles.forEach(path => {
+		console.log('deleting temppath:', path);
+		rimraf.sync(path);
+	});
+});