Skip to content

[All] Lift scope definition  #1017

Open
@jjenzz

Description

@jjenzz

Stemmed from this PR feedback #1007 (comment)

I wanted to keep the scope as __scopeTooltip but using the tooltip part name for the scope would have generated eslint no-use-before-define errors. Moving it alongside the tooltip part meant that the TooltipProvider would get the same errors when calling createTooltipContext.

Benoit and I agreed that using the part name for the scope name was probably the wrong approach and that the file name is probably more accurate.

I've lifted the scope away from all parts in Tooltip so that it is the first thing declared (in isolation) but we agreed it would be good to standardise this across the codebase when we have some time.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions