fix: dropdown menu immediately closes on Android Firefox mobile #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaance
requested changes
Sep 26, 2024
Comment on lines
+127
to
+129
| onFocusCapture={(event)=>{ | ||
| event.stopPropagation(); | ||
| }} |
There was a problem hiding this comment.
We want to treat this like any other event handle and compose it with the consumer's onFocusCapture prop
Suggested change
| onFocusCapture={(event)=>{ | |
| event.stopPropagation(); | |
| }} | |
| onFocusCapture={composeEventHandlers(props.onFocusCapture, (event)=>{ | |
| event.stopPropagation(); | |
| })} |
chaance
requested review from
StephenHaney,
lucasmotta and
hadihallak
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2565
onFocusCapture is triggered while clicking on dropdown trigger.This prevented by stopping propogation of focus event from DropdownMenuTrigger component