fix(react-dismissable-layer): body pointer-events cleanup#3871
Open
shane-tierney-shield-ai wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: c88fe89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
DismissableLayercleanup when a layer that previously disabled outside pointer events is removed fromlayersWithOutsidePointerEventsDisabledbefore another disabled layer closes.Previously, the cleanup restored
document.body.style.pointerEventsbased on the disabled-layer stack size before removing the current layer from that stack. This could leave a stale layer inlayersWithOutsidePointerEventsDisabled, preventing body pointer events from being restored after the remaining disabled layer unmounted.This change removes the layer from
layersWithOutsidePointerEventsDisabledbefore checking whether body pointer events should be restored, while preserving the existinglayerscleanup behavior that maintains creation-order layering.Added a focused regression test covering this stack cleanup case.
Verification:
pnpm testpnpm buildpnpm --filter @radix-ui/react-dismissable-layer run typecheckpnpm --filter @radix-ui/react-dismissable-layer run lint