fix(Select): prevent scroll from hidden bubble input in constrained layouts#3876
Open
mixelburg wants to merge 1 commit into
Open
fix(Select): prevent scroll from hidden bubble input in constrained layouts#3876mixelburg wants to merge 1 commit into
mixelburg wants to merge 1 commit into
Conversation
…ayouts The hidden native <select> element (SelectBubbleInput) uses position:absolute but doesn't pin its location, causing it to be positioned low on the page in constrained flex layouts and extending the scrollable area. Adding top:0 and left:0 pins it to the top of its containing block. Fixes radix-ui#3875
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The hidden native select element (SelectBubbleInput) uses position: absolute (from VISUALLY_HIDDEN_STYLES) but does not pin its location to the top-left of its containing block. In constrained flex layouts (e.g. nested flex containers with height: 100dvh inside a form), the element is positioned low on the page, causing it to extend the scrollable area.
Fix
Add top: 0 and left: 0 to the SelectBubbleInput style to pin it to the top of its containing block, preventing the layout extension.
Fixes #3875