fix(navigation-menu): pass data-state to ViewportContentMounter#3923
Open
LongTangGithub wants to merge 1 commit into
Open
fix(navigation-menu): pass data-state to ViewportContentMounter#3923LongTangGithub wants to merge 1 commit into
LongTangGithub wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 8c88571 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3786
Description
NavigationMenuContenthas two rendering paths depending on whether aNavigationMenuViewportis present:NavigationMenuContentImpldirectly,with
data-statepassed explicitly. ✅ViewportContentMounter, which storesprops in a shared
Mapthat the viewport renders from.data-statewasnever included in this handoff. ❌
This meant that when using
forceMountwith aNavigationMenuViewport,the rendered content elements had no
data-stateattribute at all, making itimpossible to target open/closed states in CSS or animations.
Fix
Extract
openStatefromgetOpenState(open)into a shared variable andpass it as
data-statetoViewportContentMounter, mirroring what wasalready done for the non-viewport path.
Manual Testing
A new Storybook story
ForceMountWithViewporthas been added to reproducethis scenario. To verify:
pnpm devand open Components/NavigationMenu → ForceMountWithViewport"open"and"closed"on the corresponding content elementVideo Demo of Fix
data-attribute-fixmp4.mp4