fix(toast): reset remaining time ref when duration changes after pause / resume#3926
Open
LongTangGithub wants to merge 2 commits into
Open
fix(toast): reset remaining time ref when duration changes after pause / resume#3926LongTangGithub wants to merge 2 commits into
LongTangGithub wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 8e2ce0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2233
Description
closeTimerRemainingTimeRefis initialized once at mount with thedurationvalue and never updated when the prop changes on re-renders.This means a toast that was paused while
duration=Infinitywill holdInfinityin the ref permanently. So whendurationlater changes to a finite value, any subsequent pause/resume cycle callsstartTimer(Infinity)and the toast never auto-closes.Root cause:
On resume, the timer is restarted using this ref:
Fix:
Added a
useEffectthat syncscloseTimerRemainingTimeRefwheneverdurationchanges:Manual Testing
A new Storybook story
DurationChangeAfterPausehas been added to reproduce this scenario.pnpm devand open Components/Toast → DurationChangeAfterPauseduration=Infinity(loading state)Before fix:
InfinityAfter fix:
⏸ PAUSEDindicator also confirms pause/resume is working as expected.Video Demo
2233_fix.mp4