fix(select): use overflowX/overflowY instead of overflow shorthand in Viewport#3927
Open
LongTangGithub wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 36b4a37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chaance
requested changes
Jun 5, 2026
| ); | ||
|
|
||
| export const WithScrollArea = () => { | ||
| <div style={{ padding: 50 }}> |
Member
There was a problem hiding this comment.
You aren't actually returning the JSX here so this story renders nothing.
| "@radix-ui/react-select": patch | ||
| --- | ||
|
|
||
| Fix React warning when composing ScrollArea inside Select by replacing overflow shorthand with overflowX/overflowY longhand properties in Select.Viewport |
Member
There was a problem hiding this comment.
Suggested change
| Fix React warning when composing ScrollArea inside Select by replacing overflow shorthand with overflowX/overflowY longhand properties in Select.Viewport | |
| Fixed React warning when composing ScrollArea inside Select due to conflicting inline `overflow` styles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2059
Description
Select.Viewportwas settingoverflow: 'hidden auto'as a CSS shorthand.When a
ScrollAreais composed insideSelect.Content(as shown in the Radix docs),ScrollArea.ViewportsetsoverflowXandoverflowYas separate longhand properties.React detects this as a conflict between a shorthand and longhands on the same element during re-render and logs a warning:
Fix
Replace the
overflowshorthand inSelect.Viewportwith explicitoverflowX: 'hidden'andoverflowY: 'auto'longhand properties.This matches how
ScrollArea.Viewportalready sets its own overflow styles and eliminates the conflict.Manual Testing
A new Storybook story
WithScrollAreahas been added to reproduce this scenario. To verify:pnpm devand open Components/Select → WithScrollAreastorybook-preview-iframeScreenshot of Fix