Skip to content

Commit 319eb84

Browse files
HJSangclaude
andcommitted
Smoke the runtime-loaded rollout modules; load both CI actions from the workflow's commit
wheel_smoke imported the drivers and actors, but the default rollout function and the session server are loaded by name at run time. install-megatron-bridge had the same old-ref problem as resolve-dependency-refs. Found by an adversarial review of this PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 5a76d0e commit 319eb84

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

‎.github/workflows/_run-ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ jobs:
224224
225225
- name: Install Megatron Bridge override
226226
if: ${{ !inputs.skip_dependency_install && (github.event.inputs.ci_megatron_bridge_pr != '' || contains(github.event.pull_request.body, 'ci-megatron-bridge-pr:')) }}
227-
uses: ./.github/actions/install-megatron-bridge
227+
uses: ./.ci-actions/.github/actions/install-megatron-bridge
228228
with:
229229
ref: ${{ github.event.inputs.ci_megatron_bridge_pr || '' }}
230230
pr_body: ${{ github.event.pull_request.body || '' }}

‎.github/workflows/_run-cpu-ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ jobs:
9393
9494
- name: Install Megatron Bridge override
9595
if: ${{ github.event.inputs.ci_megatron_bridge_pr != '' || contains(github.event.pull_request.body, 'ci-megatron-bridge-pr:') }}
96-
uses: ./.github/actions/install-megatron-bridge
96+
uses: ./.ci-actions/.github/actions/install-megatron-bridge
9797
with:
9898
ref: ${{ github.event.inputs.ci_megatron_bridge_pr || '' }}
9999
pr_body: ${{ github.event.pull_request.body || '' }}

‎tests/ci/wheel_smoke.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
MEGATRON_ONLY = ("megatron", "mbridge", "transformer_engine", "apex")
1313
BACKENDS = ("fsdp", "torchtitan")
14+
# loaded by name at run time, so importing the drivers does not reach them
15+
RUNTIME_MODULES = ("miles.rollout.sglang_rollout", "miles.rollout.session.server")
1416
ENTRY_SCRIPTS = ("train.py", "train_async.py")
1517

1618

@@ -54,6 +56,8 @@ def main() -> None:
5456
for backend in BACKENDS:
5557
importlib.import_module(f"miles.backends.{backend}_utils.actor")
5658
_parse_args(backend)
59+
for module in RUNTIME_MODULES:
60+
importlib.import_module(module)
5761
_check_chat_templates()
5862

5963
print(f"wheel smoke passed: {', '.join(BACKENDS)} without Megatron")

0 commit comments

Comments
 (0)