Skip to content

Commit 6045ed4

Browse files
ci(rocm): register ROCm CI for all 8-GPU stage-c-8-gpu-mi300x tests
Add register_rocm_ci() alongside each existing register_cuda_ci() in the stage-c-8-gpu-h100 suite so the MI300X dispatch workflow runs the full 8-GPU test set via HIP/CUDA compatibility. Also renames the 8-GPU ROCm suite from "stage-c-8-gpu-mi350" to "stage-c-8-gpu-mi300x" (matching the PR stage/runner naming) in run_suite.py and all register_rocm_ci calls. 34 test files, matching est_time + labels + disabled flags.
1 parent 16a70ef commit 6045ed4

35 files changed

Lines changed: 105 additions & 35 deletions

‎tests/ci/run_suite.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"stage-c-2-gpu-h200",
3939
],
4040
HWBackend.ROCM: [
41-
"stage-c-8-gpu-mi350",
41+
"stage-c-8-gpu-mi300x",
4242
"stage-c-4-gpu-mi350",
4343
"stage-c-2-gpu-mi350",
4444
],

‎tests/e2e/ckpt/test_glm47_flash_ckpt.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
import os
22

3-
from tests.ci.ci_register import register_cuda_ci
3+
from tests.ci.ci_register import register_cuda_ci, register_rocm_ci
44

55
import miles.utils.external_utils.command_utils as U
66

77
# FIXME: need to modify megatron, better fix later.
88
register_cuda_ci(est_time=2400, suite="stage-c-8-gpu-h100", labels=["ckpt"], disabled="Disabled due to bugs.")
9+
register_rocm_ci(est_time=2400, suite="stage-c-8-gpu-mi300x", labels=["ckpt"], disabled="Disabled due to bugs.")
910

1011
ENABLE_EVAL = 0
1112
USE_DEEPEP = 0

‎tests/e2e/ckpt/test_qwen3_4B_ckpt.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import miles.utils.external_utils.command_utils as U
66

77
register_cuda_ci(est_time=1200, suite="stage-c-8-gpu-h100", labels=["ckpt"])
8-
register_rocm_ci(est_time=1200, suite="stage-c-8-gpu-mi350", labels=["ckpt"])
8+
register_rocm_ci(est_time=1200, suite="stage-c-8-gpu-mi300x", labels=["ckpt"])
99

1010
ENABLE_EVAL = bool(int(os.environ.get("MILES_TEST_ENABLE_EVAL", "1")))
1111

‎tests/e2e/fsdp/test_qwen3_0.6B_fsdp_distributed.py‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import os
22

3-
from tests.ci.ci_register import register_cuda_ci
3+
from tests.ci.ci_register import register_cuda_ci, register_rocm_ci
44

55
import miles.utils.external_utils.command_utils as U
66

@@ -10,6 +10,12 @@
1010
labels=["fsdp"],
1111
disabled="FSDP backend has known issues, not actively maintained",
1212
)
13+
register_rocm_ci(
14+
est_time=600,
15+
suite="stage-c-8-gpu-mi300x",
16+
labels=["fsdp"],
17+
disabled="FSDP backend has known issues, not actively maintained",
18+
)
1319

1420
MODEL_NAME = "Qwen3-0.6B"
1521
NUM_GPUS = 8

‎tests/e2e/fsdp/test_qwen3_0.6B_megatron_fsdp_align.py‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import os
22

3-
from tests.ci.ci_register import register_cuda_ci
3+
from tests.ci.ci_register import register_cuda_ci, register_rocm_ci
44

55
import miles.utils.external_utils.command_utils as U
66

@@ -10,6 +10,12 @@
1010
labels=["fsdp"],
1111
disabled="FSDP backend has known issues, not actively maintained",
1212
)
13+
register_rocm_ci(
14+
est_time=900,
15+
suite="stage-c-8-gpu-mi300x",
16+
labels=["fsdp"],
17+
disabled="FSDP backend has known issues, not actively maintained",
18+
)
1319

1420

1521
MODEL_NAME = "Qwen3-0.6B"

‎tests/e2e/fsdp/test_qwen3_4B_fsdp_true_on_policy.py‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import os
22

3-
from tests.ci.ci_register import register_cuda_ci
3+
from tests.ci.ci_register import register_cuda_ci, register_rocm_ci
44

55
import miles.utils.external_utils.command_utils as U
66

@@ -10,6 +10,12 @@
1010
labels=["fsdp"],
1111
disabled="FSDP backend has known issues, not actively maintained",
1212
)
13+
register_rocm_ci(
14+
est_time=600,
15+
suite="stage-c-8-gpu-mi300x",
16+
labels=["fsdp"],
17+
disabled="FSDP backend has known issues, not actively maintained",
18+
)
1319

1420
ENABLE_EVAL = bool(int(os.environ.get("MILES_TEST_ENABLE_EVAL", "1")))
1521
NUM_GPUS = 8

‎tests/e2e/megatron/test_deepseek_v32_5layer_fp8.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@
1313
_prepare_download,
1414
_prepare_megatron_ckpt,
1515
)
16-
from tests.ci.ci_register import register_cuda_ci
16+
from tests.ci.ci_register import register_cuda_ci, register_rocm_ci
1717

1818
register_cuda_ci(est_time=1800, suite="stage-c-8-gpu-h100", labels=["model-scripts"])
19+
register_rocm_ci(est_time=1800, suite="stage-c-8-gpu-mi300x", labels=["model-scripts"])
1920

2021

2122
def _args() -> ScriptArgs:

‎tests/e2e/megatron/test_deepseek_v4_flash_4layer_ci.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import os
22

33
from scripts.run_deepseek_v4 import ScriptArgs, _prepare_download, _prepare_single, _prepare_spmd, _train
4-
from tests.ci.ci_register import register_cuda_ci
4+
from tests.ci.ci_register import register_cuda_ci, register_rocm_ci
55

66
register_cuda_ci(est_time=1800, suite="stage-c-8-gpu-h100", labels=["model-scripts"])
7+
register_rocm_ci(est_time=1800, suite="stage-c-8-gpu-mi300x", labels=["model-scripts"])
78

89

910
def _args() -> ScriptArgs:

‎tests/e2e/megatron/test_glm47_flash/test_r3_mtp.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import os
22

3-
from tests.ci.ci_register import register_cuda_ci
3+
from tests.ci.ci_register import register_cuda_ci, register_rocm_ci
44
from tests.e2e.megatron.test_glm47_flash._common import CaseConfig, execute, prepare
55

66
register_cuda_ci(est_time=1100, suite="stage-c-8-gpu-h100", labels=["megatron"])
7+
register_rocm_ci(est_time=1100, suite="stage-c-8-gpu-mi300x", labels=["megatron"])
78

89
CASE = CaseConfig(
910
use_deepep=False,

‎tests/e2e/megatron/test_glm47_flash/test_r3_mtp_deepep.py‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import os
22

3-
from tests.ci.ci_register import register_cuda_ci
3+
from tests.ci.ci_register import register_cuda_ci, register_rocm_ci
44
from tests.e2e.megatron.test_glm47_flash._common import CaseConfig, execute, prepare
55

66
# FIXME: sglang deepep code path bug.
@@ -10,6 +10,12 @@
1010
labels=["megatron"],
1111
disabled="Disabled due to sglang deepep code path bug.",
1212
)
13+
register_rocm_ci(
14+
est_time=900,
15+
suite="stage-c-8-gpu-mi300x",
16+
labels=["megatron"],
17+
disabled="Disabled due to sglang deepep code path bug.",
18+
)
1319

1420
CASE = CaseConfig(
1521
use_deepep=True,

0 commit comments

Comments
 (0)