Slow down consensus (increase timeouts) when vertex store is close to being full (#859)

Author: LukasGasior1

core/src/main/java/com/radixdlt/RadixNodeModule.java

@@ -76,6 +76,7 @@
 import com.radixdlt.consensus.ProposalLimitsConfig;
 import com.radixdlt.consensus.bft.*;
 import com.radixdlt.consensus.epoch.EpochsConsensusModule;
+import com.radixdlt.consensus.liveness.PacemakerTimeoutCalculatorConfig;
 import com.radixdlt.consensus.sync.BFTSyncPatienceMillis;
 import com.radixdlt.consensus.vertexstore.VertexStoreConfig;
 import com.radixdlt.environment.*;
@@ -156,11 +157,14 @@ protected void configure() {
         .annotatedWith(BFTSyncPatienceMillis.class)
         .to(properties.get("bft.sync.patience", 200));
 
-    // Max timeout = (1.2^8)×3 ~= 13s
-    bindConstant().annotatedWith(PacemakerBaseTimeoutMs.class).to(3000L);
-    bindConstant().annotatedWith(PacemakerBackoffRate.class).to(1.2);
-    bindConstant().annotatedWith(PacemakerMaxExponent.class).to(8);
-    bindConstant().annotatedWith(AdditionalRoundTimeIfProposalReceivedMs.class).to(30_000L);
+    bind(PacemakerTimeoutCalculatorConfig.class)
+        .toInstance(PacemakerTimeoutCalculatorConfig.defaultConfig());
+
+    // Delayed resolution is disabled for now because we cannot create QCs on fallback vertices,
+    // because we don't just sign the ledger header, but also the BFT header,
+    // which captures the previous certificate chain,
+    // and all the nodes have a different certificate chain for their fallback vertex.
+    // TODO: consider reviving this feature or clean it up
     bindConstant().annotatedWith(TimeoutQuorumResolutionDelayMs.class).to(0L);
 
     final var vertexStoreConfig =

core/src/main/java/com/radixdlt/api/system/routes/ConfigurationHandler.java

@@ -70,8 +70,8 @@
 import com.radixdlt.api.system.generated.models.BFTConfiguration;
 import com.radixdlt.api.system.generated.models.MempoolConfiguration;
 import com.radixdlt.api.system.generated.models.SystemConfigurationResponse;
-import com.radixdlt.consensus.bft.PacemakerBaseTimeoutMs;
 import com.radixdlt.consensus.bft.Self;
+import com.radixdlt.consensus.liveness.PacemakerTimeoutCalculatorConfig;
 import com.radixdlt.consensus.sync.BFTSyncPatienceMillis;
 import com.radixdlt.crypto.ECDSASecp256k1PublicKey;
 import com.radixdlt.mempool.MempoolThrottleMs;
@@ -81,7 +81,7 @@
 
 public final class ConfigurationHandler extends SystemJsonHandler<SystemConfigurationResponse> {
 
-  private final long pacemakerTimeout;
+  private final PacemakerTimeoutCalculatorConfig pacemakerTimeoutCalculatorConfig;
   private final int bftSyncPatienceMillis;
   private final long mempoolThrottleMs;
   private final SyncRelayConfig syncRelayConfig;
@@ -93,7 +93,7 @@ public final class ConfigurationHandler extends SystemJsonHandler<SystemConfigur
   @Inject
   ConfigurationHandler(
       @Self ECDSASecp256k1PublicKey self,
-      @PacemakerBaseTimeoutMs long pacemakerTimeout,
+      PacemakerTimeoutCalculatorConfig pacemakerTimeoutCalculatorConfig,
       @BFTSyncPatienceMillis int bftSyncPatienceMillis,
       @MempoolThrottleMs long mempoolThrottleMs,
       SyncRelayConfig syncRelayConfig,
@@ -102,7 +102,7 @@ public final class ConfigurationHandler extends SystemJsonHandler<SystemConfigur
       ProtocolConfig protocolConfig) {
     super();
     this.self = self;
-    this.pacemakerTimeout = pacemakerTimeout;
+    this.pacemakerTimeoutCalculatorConfig = pacemakerTimeoutCalculatorConfig;
     this.bftSyncPatienceMillis = bftSyncPatienceMillis;
     this.mempoolThrottleMs = mempoolThrottleMs;
     this.syncRelayConfig = syncRelayConfig;
@@ -120,7 +120,7 @@ public SystemConfigurationResponse handleRequest() {
         .bft(
             new BFTConfiguration()
                 .bftSyncPatience(bftSyncPatienceMillis)
-                .pacemakerTimeout(pacemakerTimeout))
+                .pacemakerTimeout(pacemakerTimeoutCalculatorConfig.baseTimeoutMs()))
         .mempool(new MempoolConfiguration().maxSize(0).throttle(mempoolThrottleMs))
         .sync(systemModelMapper.syncConfiguration(syncRelayConfig))
         .networking(systemModelMapper.networkingConfiguration(self, p2PConfig))

core/src/main/java/com/radixdlt/consensus/bft/AdditionalRoundTimeIfProposalReceivedMs.java

@@ -95,8 +95,8 @@
 public class EpochsConsensusModule extends AbstractModule {
   @Override
   protected void configure() {
-    bind(ExponentialPacemakerTimeoutCalculator.class).in(Scopes.SINGLETON);
-    bind(PacemakerTimeoutCalculator.class).to(ExponentialPacemakerTimeoutCalculator.class);
+    bind(MultiFactorPacemakerTimeoutCalculator.class).in(Scopes.SINGLETON);
+    bind(PacemakerTimeoutCalculator.class).to(MultiFactorPacemakerTimeoutCalculator.class);
 
     OptionalBinder.newOptionalBinder(
         binder(), EpochManager.class); // So that this is consistent with tests