Add comprehensive lookups documentation #1164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Document all lookup types (Sampled, Categorical, Cyclic, NoLookup, Transformed) - Explain trait system (Order, Sampling, Span, Locus) - Cover common operations (bounds, intervalbounds, predicates, set) - Add guide for implementing custom lookups - Include example: LogLookup with custom selector behavior - Include example: MatrixLookup with internal dimensions (X, Y) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Collaborator
Claude sucks! 😄, I'm starting to hate these long summaries. BTW, what is the motivation for this? I feel that this might be too repetitive in some points, looking at https://rafaqz.github.io/DimensionalData.jl/stable/api/lookuparrays#Lookups |
Collaborator
Author
|
Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add Base methods: parent, size, length, axes, firstindex, lastindex, getindex - Add Lookup interface: order, metadata, span, sampling - Add rebuild with standard data= kwarg plus coords= extension - Add hasinternaldimensions trait - Add dims methods for integration with Dimensions module - Export coords, coord_dim, grid_position accessors Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add getindex/view for AbstractVector to slice both data and coords - Add slice_coords to slice coords along other dimensions (e.g., face) - Export slice_coords Co-Authored-By: Claude Opus 4.5 <[email protected]>
Returns coordinate extent (min, max) from the coords matrix. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Returns NoLookup when dimension is reduced. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Validates axis length matches lookup data length. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Tests for construction, slicing, bounds, rebuild, dims, reducelookup, and DimArray integration. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Adds FacedGridLookup section to the Lookup Types tabs in lookups.md. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/src/lookups.md)🤖 Generated with Claude Code