Skip to content

Commit 666b59b

Browse files
committed
pass sendInvite params as an object
1 parent f80b686 commit 666b59b

File tree

2 files changed

+22
-15
lines changed

2 files changed

+22
-15
lines changed

packages/server/src/app.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,12 +180,13 @@ const apiRoutes: Array<RouteHandler<ApiLocation>> = [
180180
},
181181
{
182182
location: sendInviteApiLocation,
183-
handler: meRoutes.sendInvite(
183+
handler: meRoutes.sendInvite({
184184
config,
185+
storage,
185186
sgMail,
186187
membersCollection,
187188
operationsCollection
188-
)
189+
})
189190
},
190191
{
191192
location: mintApiLocation,

packages/server/src/routes/me/sendInvite.ts

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ import {
2020
movePrivateVideoToPublicInviteVideo,
2121
movePrivateInviteVideoToPublicBucket,
2222
videoPaths,
23-
getPublicUrlForPath
23+
getPublicUrlForPath,
24+
BucketStorage
2425
} from "../../helpers/legacyVideoMethods";
25-
import { Storage } from "@google-cloud/storage";
2626

2727
interface DynamicTemplateData {
2828
inviter_fullname: string;
@@ -52,7 +52,7 @@ function createVideoReference(
5252

5353
async function LEGACY_createVideoReference(
5454
config: Config,
55-
storage: Storage,
55+
storage: BucketStorage,
5656
body: SendInviteApiEndpoint["call"]["request"]["body"]
5757
): Promise<VideoReference> {
5858
if ("videoReference" in body) {
@@ -99,20 +99,26 @@ async function LEGACY_createVideoReference(
9999
};
100100
}
101101

102-
export const sendInvite = (
103-
config: Config,
104-
storage: Storage,
105-
sgMail: { send: (message: EmailMessage) => void },
106-
members: CollectionReference,
107-
operations: CollectionReference
108-
) =>
102+
export const sendInvite = ({
103+
config,
104+
storage,
105+
sgMail,
106+
membersCollection,
107+
operationsCollection
108+
}: {
109+
config: Config;
110+
storage: BucketStorage;
111+
sgMail: { send: (message: EmailMessage) => void };
112+
membersCollection: CollectionReference;
113+
operationsCollection: CollectionReference;
114+
}) =>
109115
createApiRoute<SendInviteApiEndpoint>(async (call, loggedInMemberToken) => {
110116
const loggedInMemberId = loggedInMemberToken.uid;
111-
const loggedInMember = await members.doc(loggedInMemberId).get();
117+
const loggedInMember = await membersCollection.doc(loggedInMemberId).get();
112118

113119
await validateAbilityToCreateOperation(
114120
OperationType.INVITE,
115-
operations,
121+
operationsCollection,
116122
undefined,
117123
loggedInMember
118124
);
@@ -157,7 +163,7 @@ export const sendInvite = (
157163
videoReference
158164
}
159165
};
160-
await operations.doc().create(newInvite);
166+
await operationsCollection.doc().create(newInvite);
161167

162168
const loggedInFullName = loggedInMember.get("full_name");
163169

0 commit comments

Comments
 (0)