Skip to content

Commit b89f01f

Browse files
pbstriker38rosa
authored andcommitted
Move inline styles to stylesheet
1 parent 07fe9ce commit b89f01f

File tree

7 files changed

+40
-11
lines changed

7 files changed

+40
-11
lines changed

app/assets/stylesheets/mission_control/jobs/jobs.css

Lines changed: 31 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,35 @@
22
width: 15rem;
33
}
44

5-
.jobs td {
6-
word-break: break-all;
5+
table.jobs {
6+
td {
7+
word-break: break-all;
8+
}
9+
th.job-header{
10+
width: 30%;
11+
}
12+
th.duration-header {
13+
width: 20%;
14+
}
15+
&.queues th.job-header {
16+
width: 30%;
17+
}
18+
&.failed th.job-header {
19+
width: 35%;
20+
}
21+
&.in_progress th.job-header {
22+
width: 50%;
23+
}
24+
&.blocked th.job-header {
25+
width: 45%;
26+
}
27+
&.scheduled th.job-header {
28+
width: 60%;
29+
}
30+
&.finished th.job-header {
31+
width: 65%;
32+
}
33+
&.workers th.job-header {
34+
width: 40%;
35+
}
736
}

app/views/mission_control/jobs/jobs/_filters.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414

1515
<%= hidden_field_tag :server_id, MissionControl::Jobs::Current.server.id %>
1616

17-
<datalist id="job-classes" style="display: none;">
17+
<datalist id="job-classes" class="is-hidden">
1818
<% job_class_names.each do |job_class_name| %>
1919
<option value="<%= job_class_name %>" />
2020
<% end %>
2121
</datalist>
2222

23-
<datalist id="queue-names" style="display: none;">
23+
<datalist id="queue-names" class="is-hidden">
2424
<% queue_names.each do |queue_name| %>
2525
<option value="<%= queue_name %>" />
2626
<% end %>

app/views/mission_control/jobs/jobs/_jobs_page.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<table class="jobs <%= jobs_status %> table queues is-hoverable is-fullwidth">
22
<thead>
33
<tr>
4-
<th style="width: 35%;">Job</th>
4+
<th class="job-header">Job</th>
55
<% attribute_names_for_job_status(jobs_status).each do |attribute| %>
66
<th><%= attribute %></th>
77
<% end %>

app/views/mission_control/jobs/queues/index.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
<tbody>
55
<thead>
66
<tr>
7-
<th style="width: 50%;">Queue</th>
8-
<th style="width: 30%;">Pending jobs</th>
7+
<th>Queue</th>
8+
<th>Pending jobs</th>
99
<th></th>
1010
</tr>
1111
</thead>

app/views/mission_control/jobs/queues/show.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<tbody>
1010
<thead>
1111
<tr>
12-
<th style="width: 30%;">Job</th>
12+
<th class="job-header">Job</th>
1313
<th></th>
1414
</tr>
1515
</thead>

app/views/mission_control/jobs/shared/_jobs.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
<tbody>
33
<thead>
44
<tr>
5-
<th style="width: 30%;">Job</th>
5+
<th class="job-header">Job</th>
66
<th></th>
7-
<th style="width: 20%;"></th>
7+
<th class="duration-header"></th>
88
</tr>
99
</thead>
1010

app/views/mission_control/jobs/workers/_workers_page.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<tr>
55
<th>Worker</th>
66
<th>Hostname</th>
7-
<th style="width: 35%;">Jobs</th>
7+
<th class="job-header">Jobs</th>
88
<th>Last heartbeat</th>
99
</tr>
1010
</thead>

0 commit comments

Comments
 (0)