Repository navigation
Commit 00ddcd0
Drop the dummy app's tooling for asset modes that no longer exist
#3751 removed the :webpacker, :vite and :importmap asset sources but
left their plumbing in the dummy app. None of it is reachable now:
- link_tree ../../../../../src in the Sprockets manifest exposed the
gem's ES module sources so the importmap pins could resolve them as
assets. The engine no longer puts src/ on the asset path, so the line
links nothing; dropping it changes only the manifest's own digest. It
reached outside the image during the Docker build too, which is what
the sed alongside it was stripping.
- The FontAwesome path in config/initializers/assets.rb fed the webfonts
from node_modules to the importmap and webpack builds. The prebuilt
bundle carries them.
- vite.config.ts, postcss.config.js, babel.config.js and .browserslistrc
configure bundlers the dummy app no longer runs. webpack.config.js was
not merely idle: the installer reads its presence as :external, so
auto-detection inside the dummy app resolved to the wrong pipeline.
- app/javascript/application.js imports packages that are no longer
dependencies, and host-side bundling is already covered by the
:external mode's app/frontend entrypoints.
- vendor/javascript is where importmap-rails vendors its pins.
- Procfile.dev ran a build:css script and bin/vite, neither of which
exists.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent d593bca commit 00ddcd0
12 files changed
Lines changed: 0 additions & 155 deletions
File tree
- spec/dummy_app
- app
- assets/config
- javascript
- config/initializers
- vendor/javascript
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | 23 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | 54 | | |
56 | 55 | | |
57 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
This file was deleted.
Whitespace-only changes.
0 commit comments