Skip to content

Commit 00ddcd0

Browse files
mshibuyaclaude
andcommitted
Drop the dummy app's tooling for asset modes that no longer exist
#3751 removed the :webpacker, :vite and :importmap asset sources but left their plumbing in the dummy app. None of it is reachable now: - link_tree ../../../../../src in the Sprockets manifest exposed the gem's ES module sources so the importmap pins could resolve them as assets. The engine no longer puts src/ on the asset path, so the line links nothing; dropping it changes only the manifest's own digest. It reached outside the image during the Docker build too, which is what the sed alongside it was stripping. - The FontAwesome path in config/initializers/assets.rb fed the webfonts from node_modules to the importmap and webpack builds. The prebuilt bundle carries them. - vite.config.ts, postcss.config.js, babel.config.js and .browserslistrc configure bundlers the dummy app no longer runs. webpack.config.js was not merely idle: the installer reads its presence as :external, so auto-detection inside the dummy app resolved to the wrong pipeline. - app/javascript/application.js imports packages that are no longer dependencies, and host-side bundling is already covered by the :external mode's app/frontend entrypoints. - vendor/javascript is where importmap-rails vendors its pins. - Procfile.dev ran a build:css script and bin/vite, neither of which exists. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent d593bca commit 00ddcd0

12 files changed

Lines changed: 0 additions & 155 deletions

File tree

‎spec/dummy_app/.browserslistrc‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎spec/dummy_app/.gitignore‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,4 @@
2020
/public/system
2121

2222
/public/assets
23-
/public/packs
24-
/public/packs-test
25-
/public/vite*
2623
/node_modules
27-
/yarn-error.log
28-
/yarn.lock
29-
yarn-debug.log*
30-
.yarn-integrity

‎spec/dummy_app/Dockerfile‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ RUN bundle install && \
5151
# RUN npm install
5252

5353
# Precompiling assets for production without requiring secret RAILS_MASTER_KEY
54-
RUN sed -i "/link_tree ..\/..\/..\//d" app/assets/config/manifest.js
5554
RUN SECRET_KEY_BASE=DUMMY ./bin/rails assets:precompile db:setup
5655

5756
# Final stage for app image

‎spec/dummy_app/Procfile.dev‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
11
web: bin/rails server -p 3000
2-
css: yarn build:css --watch
3-
vite: bin/vite dev
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
//= link_tree ../images
2-
//= link_tree ../../../../../src .js
32
//= link turbo.js
43
//= link application.css

‎spec/dummy_app/app/javascript/application.js‎

Lines changed: 0 additions & 4 deletions
This file was deleted.

‎spec/dummy_app/babel.config.js‎

Lines changed: 0 additions & 82 deletions
This file was deleted.

‎spec/dummy_app/config/initializers/assets.rb‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
# Add additional assets to the asset load path
99
# Rails.application.config.assets.paths << Emoji.images_path
10-
Rails.application.config.assets.paths << Rails.root.join('node_modules/@fortawesome/fontawesome-free/webfonts') if Rails.application.config.respond_to?(:assets)
1110

1211
# Precompile additional assets.
1312
# application.js, application.css, and all non-JS/CSS in app/assets folder are already added.

‎spec/dummy_app/postcss.config.js‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎spec/dummy_app/vendor/javascript/.keep‎

Whitespace-only changes.

0 commit comments

Comments
 (0)