Fix nonce issue for dropped transactions (#6402)

* Bump nonce persist version

* Remove unnecessary nonce persist migration

* Treat API responses that have a txn object status the same as not having a tx object yet, as it means it has not been indexed by our third parties yet

Author: jinchung

src/resources/transactions/transaction.ts

@@ -46,7 +46,7 @@ export const fetchTransaction = async ({
     });
 
     const tx = response?.data?.payload?.transaction;
-    if (!tx) {
+    if (!tx || !tx?.status || (tx?.status as string) === '') {
       return null;
     }
     const parsedTx = await parseTransaction(tx, currency, chainId);

src/state/nonces/index.ts

@@ -106,27 +106,7 @@ export const nonceStore = createStore<CurrentNonceState<Nonces>>(
   {
     persist: {
       name: 'nonces',
-      version: 1,
-      migrate: (persistedState: unknown, version: number) => {
-        if (version === 0) {
-          const chainsIdByName = useBackendNetworksStore.getState().getChainsIdByName();
-          const oldState = persistedState as CurrentNonceState<NoncesV0>;
-          const newNonces: CurrentNonceState<Nonces>['nonces'] = {};
-          for (const [address, networkNonces] of Object.entries(oldState.nonces)) {
-            for (const [network, nonceData] of Object.entries(networkNonces)) {
-              if (!newNonces[address]) {
-                newNonces[address] = {} as Record<ChainId, NonceData>;
-              }
-              newNonces[address][chainsIdByName[network as Network]] = nonceData;
-            }
-          }
-          return {
-            ...oldState,
-            nonces: newNonces,
-          };
-        }
-        return persistedState as CurrentNonceState<Nonces>;
-      },
+      version: 2,
     },
   }
 );