fix: prevent eth_getBalance when showBalance is disabled#2683
Open
minato32 wants to merge 1 commit into
Open
Conversation
|
@minato32 is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 72c77f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
useProfilenow passes an explicitquery.enabledtouseBalance, gated onBoolean(includeBalance && address). Previously the hook disabled the query implicitly by passingaddress: undefinedwhenincludeBalancewasfalse. Switching to an explicitenabledflag guarantees the underlyingeth_getBalanceRPC call is skipped whenever the consumer has opted out (viashowBalance={false}on<ConnectButton />) or the account modal is closed.What to test
<ConnectButton showBalance={false} />, confirmeth_getBalanceis not requested when<RainbowKitProvider />mounts/re-renders.<AccountModal />mounted butopen={false}, confirmeth_getBalanceis not requested.showBalanceenabled (default or explicit), confirm the balance is fetched and displayed as before.Closes #2177