Skip to content

if a strat eval reverts in take orders, don't revert the whole take orders, instead skip the order #169

Open
@thedavidmeister

Description

@thedavidmeister

this one is a bit subtle

consider the case where calculate io does not error, but handle io does error

at this point we've already called store for the kvs from calculate io!

if we don't rollback the transaction we will corrupt the interpreter storage for these orders

otoh we want to gracefully drop orders as much as possible in the loop rather than have an error prevent us taking potentially viable orders further down the list

potentially we have to revert on handle io reverts, but can gracefully drop calculate io reverts (and not update storage!)

Metadata

Metadata

Assignees

No one assigned

    Labels

    contractRelated to solidity contracts

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions