Merge pull request #253 from gildlab/2025-10-27-pyth

pyth oracle

Author: thedavidmeister

.gas-snapshot

@@ -166,7 +166,7 @@ OffchainAssetReceiptVaultOwnerFreezeUntilTest:testTokenDepositFrozen(uint256) (r
 OffchainAssetReceiptVaultOwnerFreezeUntilTest:testTokenMintFrozen(uint256) (runs: 256, μ: 369652, ~: 376465)
 OffchainAssetReceiptVaultOwnerFreezeUntilTest:testTokenRedeemFrozen(uint256) (runs: 256, μ: 334722, ~: 340175)
 OffchainAssetReceiptVaultOwnerFreezeUntilTest:testTokenRedepositFrozen(uint256) (runs: 256, μ: 443837, ~: 450650)
-OffchainAssetReceiptVaultOwnerFreezeUntilTest:testTokenTransferFroze(uint256) (runs: 257, μ: 326674, ~: 333569)
+OffchainAssetReceiptVaultOwnerFreezeUntilTest:testTokenTransferFroze(uint256) (runs: 256, μ: 326750, ~: 333569)
 OffchainAssetReceiptVaultOwnerFreezeUntilTest:testTokenTransferNotFroze() (gas: 258229)
 OffchainAssetReceiptVaultOwnerFreezeUntilTest:testTokenWithdrawFrozen(uint256) (runs: 256, μ: 334875, ~: 340328)
 OffchainAssetReceiptVaultPaymentMintAuthorizerV1ConstructTest:testOffchainAssetReceiptVaultPaymentMintAuthorizerV1Construct() (gas: 2516599)

.gitmodules

@@ -22,3 +22,6 @@
 [submodule "lib/rain.verify.interface"]
 	path = lib/rain.verify.interface
 	url = https://github.com/rainlanguage/rain.verify.interface
+[submodule "lib/rain.pyth"]
+	path = lib/rain.pyth
+	url = https://github.com/rainlanguage/rain.pyth

foundry.toml

@@ -16,6 +16,7 @@ remappings = [
     "chainlink/=lib/rain.chainlink/lib/chainlink/contracts/src/",
     "rain.math.fixedpoint/=lib/rain.math.fixedpoint/src/",
     "rain.extrospection/=lib/rain.factory/lib/rain.extrospection/src/",
+    "rain.math.float/=lib/rain.flare/lib/rain.interpreter/lib/rain.interpreter.interface/lib/rain.math.float/src/",
 ]
 
 bytecode_hash = "none"

lib/rain.pyth

@@ -1,4 +1,4 @@
 {
   "detectors_to_exclude": "solc-version,block-timestamp,unused-imports,different-pragma-directives-are-used,assembly-usage",
-  "filter_paths": "lib/openzeppelin-contracts,lib/rain.tier.interface,test/,node_modules"
+  "filter_paths": "lib/openzeppelin-contracts,lib/rain.tier.interface,test/,node_modules,rain.math.float,rain.math.fixedpoint"
 }

slither.config.json

@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: LicenseRef-DCL-1.0
+// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd
+pragma solidity =0.8.25;
+
+import {PriceOracleV2} from "../../abstract/PriceOracleV2.sol";
+import {IPyth} from "pyth-sdk/IPyth.sol";
+import {PythStructs} from "pyth-sdk/PythStructs.sol";
+import {LibDecimalFloat, Float} from "rain.math.float/lib/LibDecimalFloat.sol";
+
+error NonPositivePrice(int256 price);
+
+struct PythOracleConfig {
+    bytes32 priceFeedId;
+    uint256 staleAfter;
+    IPyth pythContract;
+}
+
+contract PythOracle is PriceOracleV2 {
+    event Construction(address sender, PythOracleConfig config);
+
+    //slither-disable-next-line naming-convention
+    bytes32 public immutable I_PRICE_FEED_ID;
+    //slither-disable-next-line naming-convention
+    uint256 public immutable I_STALE_AFTER;
+    //slither-disable-next-line naming-convention
+    IPyth public immutable I_PYTH_CONTRACT;
+
+    constructor(PythOracleConfig memory config) {
+        I_PRICE_FEED_ID = config.priceFeedId;
+        I_STALE_AFTER = config.staleAfter;
+        I_PYTH_CONTRACT = config.pythContract;
+
+        emit Construction(msg.sender, config);
+    }
+
+    function _price() internal virtual override returns (uint256) {
+        // Slither false positive, confidence is checked here.
+        // slither-disable-next-line pyth-unchecked-confidence
+        PythStructs.Price memory priceData = I_PYTH_CONTRACT.getPriceNoOlderThan(I_PRICE_FEED_ID, I_STALE_AFTER);
+        int256 conservativePrice = int256(priceData.price) - int256(uint256(priceData.conf));
+        if (conservativePrice <= 0) {
+            revert NonPositivePrice(conservativePrice);
+        }
+        // It is safe to pack lossless here because the price data uses only
+        // 64 bits while we have 224 bits for a packed signed coefficient, and
+        // the exponent bit size is the same for both.
+        Float conservativePriceFloat = LibDecimalFloat.packLossless(conservativePrice, priceData.expo);
+        // We ignore precision loss here, truncating towards zero.
+        //slither-disable-next-line unused-return
+        (uint256 price18,) = LibDecimalFloat.toFixedDecimalLossy(conservativePriceFloat, 18);
+        return price18;
+    }
+}