transfers allowed certified

Author: thedavidmeister

.gas-snapshot

@@ -78,8 +78,10 @@ OffchainAssetReceiptVaultAuthorizeReceiptTransferTest:testAuthorizeReceiptTransf
 OffchainAssetReceiptVaultAuthorizeReceiptTransferTest:testAuthorizeReceiptTransferRevertExpiredCertification(uint256,uint256,string,string,uint256,uint256,uint256,bytes,uint256[],uint256[]) (runs: 270, μ: 1326542, ~: 1321243)
 OffchainAssetReceiptVaultAuthorizeTest:testAuthorizeContract(uint256,uint256,string,string) (runs: 270, μ: 1008863, ~: 1010778)
 OffchainAssetReceiptVaultAuthorizeTest:testChangeAuthorizer(uint256,uint256,string,string) (runs: 270, μ: 1340075, ~: 1341989)
-OffchainAssetReceiptVaultAuthorizerV1AuthorizeTest:testOffchainAssetReceiptVaultAuthorizerV1AuthorizeAuthorized(address,address,address,bytes) (runs: 270, μ: 2420940, ~: 2419553)
-OffchainAssetReceiptVaultAuthorizerV1AuthorizeTest:testOffchainAssetReceiptVaultAuthorizerV1AuthorizeUnauthorized(address,address,address,bytes32,bytes) (runs: 270, μ: 2223778, ~: 2223606)
+OffchainAssetReceiptVaultAuthorizerV1AuthorizeTest:testOffchainAssetReceiptVaultAuthorizerV1AuthorizeAuthorized(address,address,address,bytes) (runs: 270, μ: 2420964, ~: 2419577)
+OffchainAssetReceiptVaultAuthorizerV1AuthorizeTest:testOffchainAssetReceiptVaultAuthorizerV1AuthorizeTransferReceiptCertifyNotExpired(address,address,address,address,address,uint256[],uint256[]) (runs: 270, μ: 2301505, ~: 2298513)
+OffchainAssetReceiptVaultAuthorizerV1AuthorizeTest:testOffchainAssetReceiptVaultAuthorizerV1AuthorizeTransferSharesCertifyNotExpired(address,address,address,address,address,uint256) (runs: 270, μ: 2219100, ~: 2219100)
+OffchainAssetReceiptVaultAuthorizerV1AuthorizeTest:testOffchainAssetReceiptVaultAuthorizerV1AuthorizeUnauthorized(address,address,address,bytes32,bytes) (runs: 270, μ: 2223802, ~: 2223630)
 OffchainAssetReceiptVaultAuthorizerV1ConstructTest:testOffchainAssetReceiptVaultAuthorizerV1Construct(address,address) (runs: 270, μ: 1455228, ~: 1455228)
 OffchainAssetReceiptVaultAuthorizerV1ConstructTest:testOffchainAssetReceiptVaultAuthorizerV1Initialize(address,address,bytes32) (runs: 269, μ: 2460491, ~: 2460491)
 OffchainAssetReceiptVaultAuthorizerV1ConstructTest:testOffchainAssetReceiptVaultAuthorizerV1InitializeZeroAdmin(address) (runs: 270, μ: 1777561, ~: 1777561)

test/src/concrete/authorize/OffchainAssetReceiptVaultAuthorizerV1.authorize.t.sol

@@ -20,6 +20,7 @@ import {
     FREEZE_HANDLER
 } from "src/concrete/authorize/OffchainAssetReceiptVaultAuthorizerV1.sol";
 import {CloneFactory} from "rain.factory/concrete/CloneFactory.sol";
+import {TransferSharesStateChange, TransferReceiptStateChange} from "src/concrete/vault/OffchainAssetReceiptVault.sol";
 
 contract OffchainAssetReceiptVaultAuthorizerV1AuthorizeTest is Test {
     function testOffchainAssetReceiptVaultAuthorizerV1AuthorizeUnauthorized(
@@ -88,4 +89,73 @@ contract OffchainAssetReceiptVaultAuthorizerV1AuthorizeTest is Test {
             authorizer.authorize(user, roles[i], data);
         }
     }
+
+    /// When certification is NOT expired then all TRANSFER_SHARES are
+    /// authorized.
+    function testOffchainAssetReceiptVaultAuthorizerV1AuthorizeTransferSharesCertifyNotExpired(
+        address initialAdmin,
+        address authorizee,
+        address user,
+        address from,
+        address to,
+        uint256 amount
+    ) external {
+        vm.assume(initialAdmin != address(0));
+        vm.assume(authorizee != address(0));
+        vm.assume(initialAdmin != authorizee);
+
+        OffchainAssetReceiptVaultAuthorizerV1 authorizerImplementation = new OffchainAssetReceiptVaultAuthorizerV1();
+
+        OffchainAssetReceiptVaultAuthorizerV1Config memory config =
+            OffchainAssetReceiptVaultAuthorizerV1Config({initialAdmin: initialAdmin, authorizee: authorizee});
+
+        CloneFactory factory = new CloneFactory();
+        OffchainAssetReceiptVaultAuthorizerV1 authorizer =
+            OffchainAssetReceiptVaultAuthorizerV1(factory.clone(address(authorizerImplementation), abi.encode(config)));
+
+        authorizer.authorize(
+            user,
+            TRANSFER_SHARES,
+            abi.encode(TransferSharesStateChange({from: from, to: to, amount: amount, isCertificationExpired: false}))
+        );
+    }
+
+    /// When certification is NOT expired then all TRANSFER_RECEIPT are
+    /// authorized.
+    function testOffchainAssetReceiptVaultAuthorizerV1AuthorizeTransferReceiptCertifyNotExpired(
+        address initialAdmin,
+        address authorizee,
+        address user,
+        address from,
+        address to,
+        uint256[] memory ids,
+        uint256[] memory amounts
+    ) external {
+        vm.assume(initialAdmin != address(0));
+        vm.assume(authorizee != address(0));
+        vm.assume(initialAdmin != authorizee);
+
+        OffchainAssetReceiptVaultAuthorizerV1 authorizerImplementation = new OffchainAssetReceiptVaultAuthorizerV1();
+
+        OffchainAssetReceiptVaultAuthorizerV1Config memory config =
+            OffchainAssetReceiptVaultAuthorizerV1Config({initialAdmin: initialAdmin, authorizee: authorizee});
+
+        CloneFactory factory = new CloneFactory();
+        OffchainAssetReceiptVaultAuthorizerV1 authorizer =
+            OffchainAssetReceiptVaultAuthorizerV1(factory.clone(address(authorizerImplementation), abi.encode(config)));
+
+        authorizer.authorize(
+            user,
+            TRANSFER_RECEIPT,
+            abi.encode(
+                TransferReceiptStateChange({
+                    from: from,
+                    to: to,
+                    ids: ids,
+                    amounts: amounts,
+                    isCertificationExpired: false
+                })
+            )
+        );
+    }
 }