Skip to content

Commit ebddccc

Browse files
author
isayan
committed
fix MatchAlert
1 parent 2c29f90 commit ebddccc

File tree

9 files changed

+12
-30
lines changed

9 files changed

+12
-30
lines changed

release/YaguraExtension-v3.0.jar

-160 Bytes
Binary file not shown.

src/main/java/burp/BurpExtension.java

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,6 +1095,7 @@ public ProxyHander(MontoyaApi api) {
10951095
*/
10961096
@Override
10971097
public RequestToBeSentAction handleHttpRequestToBeSent(HttpRequestToBeSent httpRequestToBeSent) {
1098+
10981099
return RequestToBeSentAction.continueWith(httpRequestToBeSent, httpRequestToBeSent.annotations());
10991100
}
11001101

@@ -1271,25 +1272,6 @@ protected void historyLogAppend() {
12711272
}
12721273
}
12731274

1274-
/**
1275-
* processToolMessage
1276-
*
1277-
* @param toolType
1278-
* @param messageIsRequest
1279-
* @param messageInfo
1280-
* @return
1281-
*/
1282-
public HttpRequestResponse processToolMessage(
1283-
ToolType toolType,
1284-
boolean messageIsRequest,
1285-
HttpRequestResponse messageInfo) {
1286-
HttpRequestResponse httpRequestResponse = messageInfo;
1287-
if (getProperty().getMatchAlertProperty().isMatchAlertEnable() && getProperty().getMatchAlertProperty().isSelectedMatchAlert()) {
1288-
httpRequestResponse = this.matchAlertMessage(toolType, messageIsRequest, messageInfo);
1289-
}
1290-
return httpRequestResponse;
1291-
}
1292-
12931275
/**
12941276
* Request
12951277
*
@@ -1523,7 +1505,6 @@ public AutoResponderHandler(MontoyaApi api) {
15231505
public RequestToBeSentAction handleHttpRequestToBeSent(HttpRequestToBeSent httpRequestToBeSent) {
15241506
// Autoresponder
15251507
if (option.getAutoResponderProperty().getAutoResponderEnable()) {
1526-
HttpService service = httpRequestToBeSent.httpService();
15271508
final String url = httpRequestToBeSent.url();
15281509
AutoResponderItem item = option.getAutoResponderProperty().findItem(url, httpRequestToBeSent.method());
15291510
if (item != null) {

src/main/java/yagura/model/AutoResponderItem.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public static AutoResponderItem fromObjects(Object[] rows) {
8585
autoResponder.setBodyOnly(((Boolean) rows[5]));
8686
autoResponder.setContentType(((String) rows[6]));
8787
autoResponder.setReplace((String) rows[7]);
88-
autoResponder.recompileRegex();
88+
autoResponder.recompileRegex(!autoResponder.isRegexp());
8989
return autoResponder;
9090
}
9191

src/main/java/yagura/model/MatchAlertItem.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ public static MatchAlertItem fromObjects(Object[] rows) {
224224
matchAlert.setIssueName((String) rows[11]);
225225
matchAlert.setSeverity((Severity) rows[12]);
226226
matchAlert.setConfidence((Confidence) rows[13]);
227+
matchAlert.recompileRegex(!matchAlert.isRegexp());
227228
return matchAlert;
228229
}
229230

src/main/java/yagura/view/AutoResponderItemDlg.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,13 +378,14 @@ public AutoResponderItem getItem() {
378378
item.setReplace(this.txtRepReplace.getText());
379379
item.setBodyOnly(this.chkBodyOnly.isSelected());
380380
item.setContentType(ConvertUtil.toEmpty(this.cmbContentType.getEditor().getItem()));
381+
item.recompileRegex(!item.isRegexp());
381382
return item;
382383
}
383384

384385
/**
385386
* @param item the item to set
386387
*/
387-
public void setItem(AutoResponderItem item) {
388+
public void setItem(AutoResponderItem item) {
388389
if (item.getMethod() == null) {
389390
this.chkAnyMethod.setSelected(true);
390391
this.txtMethod.setText("");

src/main/java/yagura/view/AutoResponderTab.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ public void valueChanged(ListSelectionEvent e) {
238238
this.tableAutoResponder.getColumnModel().getColumn(1).setMinWidth(40);
239239
this.tableAutoResponder.getColumnModel().getColumn(1).setPreferredWidth(60);
240240
this.tableAutoResponder.getColumnModel().getColumn(1).setMaxWidth(80);
241-
241+
242242
// match
243243
// this.tableAutoResponder.getColumnModel().getColumn(2).setMinWidth(40);
244244
// this.tableAutoResponder.getColumnModel().getColumn(2).setPreferredWidth(100);
@@ -391,7 +391,6 @@ private AutoResponderItem getEditItem() {
391391
Object editRows[] = SwingUtil.editItem(this.tableAutoResponder);
392392
if (editRows != null) {
393393
item = AutoResponderItem.fromObjects(editRows);
394-
item.recompileRegex();
395394
}
396395
return item;
397396
}

src/main/java/yagura/view/MatchAlertItemDlg.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -581,13 +581,12 @@ public void componentShown(ComponentEvent e) {
581581
*/
582582
public MatchAlertItem getItem() {
583583
MatchAlertItem item = new MatchAlertItem();
584-
item.setType((String) this.cmbAlertType.getSelectedItem());
585-
item.setMatch(this.txtAlertMatch.getText());
586-
587584
item.setSmartMatch(this.chkSmartMatch.isSelected());
588585
item.setRegexp(this.chkRegExp.isSelected());
589586
item.setIgnoreCase(this.chkIgnoreCase.isSelected());
590587
item.setCaptureGroup(this.chkCaptureGroup.isSelected());
588+
item.setType((String) this.cmbAlertType.getSelectedItem());
589+
item.setMatch(this.txtAlertMatch.getText());
591590

592591
//item.setNotifyType((MatchItem.NotifyType) this.cmbAlertNotify.getSelectedItem());
593592
EnumSet<NotifyType> notifys = EnumSet.noneOf(NotifyType.class);
@@ -645,6 +644,7 @@ public MatchAlertItem getItem() {
645644
String confidence = (String) this.cmbConfidence.getSelectedItem();
646645
item.setConfidence(Confidence.parseEnum(confidence));
647646
}
647+
item.recompileRegex(!item.isRegexp());
648648
return item;
649649
}
650650

src/main/java/yagura/view/MatchReplaceItemDlg.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,13 +313,14 @@ public void windowClosing(java.awt.event.WindowEvent e) {
313313
public MatchReplaceItem getItem() {
314314
MatchReplaceItem item = new MatchReplaceItem();
315315
item.setSelected(true);
316-
item.setType((String) this.cmbRepType.getSelectedItem());
317-
item.setMatch(this.txtRepMatch.getText());
318316
item.setSmartMatch(this.chkSmartMatch.isSelected());
319317
item.setRegexp(this.chkRegExp.isSelected());
320318
item.setIgnoreCase(this.chkIgnoreCase.isSelected());
319+
item.setType((String) this.cmbRepType.getSelectedItem());
320+
item.setMatch(this.txtRepMatch.getText());
321321
item.setReplace(this.txtRepReplace.getText());
322322
item.setMetaChar(this.chkMetaChar.isSelected());
323+
item.recompileRegex(!item.isRegexp());
323324
return item;
324325
}
325326

src/main/java/yagura/view/ParamsViewTab.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,6 @@ protected void done() {
484484
};
485485
swParam.execute();
486486
// Decode状態を戻す
487-
BurpExtension.helpers().outPrintln("toggleDecode:" + toggleDecode);
488487
this.btnDecode.setSelected(toggleDecode);
489488
this.textModified = false;
490489
}

0 commit comments

Comments
 (0)