Skip to content

Commit 9022531

Browse files
LenaRudayaLenaRudaya
authored
Remove model optimization parameter (open-edge-platform#785)
1 parent d2595e2 commit 9022531

9 files changed

Lines changed: 0 additions & 42 deletions

File tree

‎application/backend/app/api/endpoints/models.py‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
"sam_model": "SAM-HQ-tiny",
4444
"encoder_model": "dinov3_small",
4545
"use_mask_refinement": False,
46-
"compile_models": False,
4746
"use_nms": True,
4847
},
4948
},
@@ -62,7 +61,6 @@
6261
"confidence_threshold": 0.42,
6362
"precision": "bf16",
6463
"use_nms": True,
65-
"compile_models": False,
6664
},
6765
},
6866
{
@@ -83,7 +81,6 @@
8381
"softmatching_bidirectional": False,
8482
"precision": "bf16",
8583
"use_nms": True,
86-
"compile_models": False,
8784
},
8885
},
8986
]
@@ -278,7 +275,6 @@ def get_model(project_id: UUID, model_id: UUID, model_service: ModelServiceDep)
278275
"sam_model": "SAM-HQ-tiny",
279276
"encoder_model": "dinov3_small",
280277
"use_mask_refinement": False,
281-
"compile_models": False,
282278
"use_nms": True,
283279
},
284280
},
@@ -303,7 +299,6 @@ def get_model(project_id: UUID, model_id: UUID, model_service: ModelServiceDep)
303299
"softmatching_bidirectional": False,
304300
"precision": "bf16",
305301
"use_nms": True,
306-
"compile_models": False,
307302
},
308303
},
309304
},

‎application/backend/app/domain/services/schemas/processor.py‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ class BaseModelConfig(BaseModel):
3232
encoder_model: str = Field(default="dinov3_small")
3333
precision: str = Field(default="bf16", description="Model precision")
3434
use_nms: bool = Field(default=True)
35-
compile_models: bool = Field(default=False)
3635

3736
@field_validator("sam_model", mode="before")
3837
@classmethod
@@ -72,7 +71,6 @@ class PerDinoConfig(BaseModelConfig):
7271
"confidence_threshold": 0.42,
7372
"precision": "bf16",
7473
"use_nms": True,
75-
"compile_models": False,
7674
}
7775
}
7876
}
@@ -96,7 +94,6 @@ class MatcherConfig(BaseModelConfig):
9694
"sam_model": "SAM-HQ-tiny",
9795
"encoder_model": "dinov3_small",
9896
"use_mask_refinement": False,
99-
"compile_models": False,
10097
"use_nms": True,
10198
}
10299
}
@@ -130,7 +127,6 @@ class SoftMatcherConfig(BaseModelConfig):
130127
"softmatching_bidirectional": False,
131128
"precision": "bf16",
132129
"use_nms": True,
133-
"compile_models": False,
134130
}
135131
}
136132
}

‎application/backend/app/runtime/core/components/factories/model.py‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ def create(cls, reference_batch: Batch | None, config: ModelConfig | None) -> Mo
3232
use_mask_refinement=config.use_mask_refinement,
3333
sam=config.sam_model,
3434
encoder_model=config.encoder_model,
35-
compile_models=config.compile_models,
3635
use_nms=config.use_nms,
3736
)
3837
return TorchModelHandler(model, reference_batch)
@@ -47,7 +46,6 @@ def create(cls, reference_batch: Batch | None, config: ModelConfig | None) -> Mo
4746
confidence_threshold=config.confidence_threshold,
4847
use_nms=config.use_nms,
4948
precision=config.precision,
50-
compile_models=config.compile_models,
5149
device=settings.device,
5250
)
5351
return TorchModelHandler(model, reference_batch)
@@ -65,7 +63,6 @@ def create(cls, reference_batch: Batch | None, config: ModelConfig | None) -> Mo
6563
softmatching_bidirectional=config.softmatching_bidirectional,
6664
use_nms=config.use_nms,
6765
precision=config.precision,
68-
compile_models=config.compile_models,
6966
device=settings.device,
7067
)
7168
return TorchModelHandler(model, reference_batch)

‎application/backend/tests/unit/runtime/core/components/factories/test_model.py‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ def test_factory_creates_matcher_model_with_config(self, mock_reference_batch, m
3232
sam_model=SAMModelName.SAM_HQ_TINY,
3333
encoder_model="dinov3_small",
3434
use_mask_refinement=True,
35-
compile_models=False,
3635
use_nms=True,
3736
)
3837

@@ -53,7 +52,6 @@ def test_factory_creates_matcher_model_with_config(self, mock_reference_batch, m
5352
use_mask_refinement=True,
5453
sam=SAMModelName.SAM_HQ_TINY,
5554
encoder_model="dinov3_small",
56-
compile_models=False,
5755
use_nms=True,
5856
)
5957
mock_handler.assert_called_once_with(mock_model_instance, mock_reference_batch)
@@ -68,7 +66,6 @@ def test_factory_creates_perdino_model_with_config(self, mock_reference_batch, m
6866
point_selection_threshold=0.65,
6967
confidence_threshold=0.42,
7068
precision="bf16",
71-
compile_models=False,
7269
use_nms=True,
7370
)
7471

@@ -90,7 +87,6 @@ def test_factory_creates_perdino_model_with_config(self, mock_reference_batch, m
9087
confidence_threshold=0.42,
9188
use_nms=True,
9289
precision="bf16",
93-
compile_models=False,
9490
device="cpu",
9591
)
9692
mock_handler.assert_called_once_with(mock_model_instance, mock_reference_batch)
@@ -108,7 +104,6 @@ def test_factory_creates_softmatcher_model_with_config(self, mock_reference_batc
108104
softmatching_score_threshold=0.5,
109105
softmatching_bidirectional=True,
110106
precision="bf16",
111-
compile_models=False,
112107
use_nms=True,
113108
)
114109

@@ -133,7 +128,6 @@ def test_factory_creates_softmatcher_model_with_config(self, mock_reference_batc
133128
softmatching_bidirectional=True,
134129
use_nms=True,
135130
precision="bf16",
136-
compile_models=False,
137131
device="cpu",
138132
)
139133
mock_handler.assert_called_once_with(mock_model_instance, mock_reference_batch)

‎application/ui/src/features/prompts/models/api/use-get-models.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ const getDefaultMatcherModel = (id: string): MatcherModel => {
3636
sam_model: 'SAM-HQ-tiny',
3737
encoder_model: 'dinov3_small',
3838
use_mask_refinement: false,
39-
compile_models: false,
4039
use_nms: true,
4140
},
4241
active: false,
@@ -58,7 +57,6 @@ const getDefaultPerDINOModel = (id: string): PerDINOModel => {
5857
confidence_threshold: 0.42,
5958
precision: 'bf16',
6059
use_nms: true,
61-
compile_models: false,
6260
},
6361
active: true,
6462
name: 'PerDINO',
@@ -82,7 +80,6 @@ const getDefaultSoftMatcherModel = (id: string): SoftMatcherModel => {
8280
softmatching_bidirectional: false,
8381
precision: 'bf16',
8482
use_nms: true,
85-
compile_models: false,
8683
},
8784
active: false,
8885
name: 'SoftMatcher',

‎application/ui/src/features/prompts/models/model-toolbar/model-configuration/model-configuration-dialog.component.tsx‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ const MatcherConfiguration = ({ model, onClose }: MatcherConfigurationProps) =>
9292
const [decoderModel, setDecoderModel] = useState<DecoderModel>(model.config.sam_model);
9393
const [precision, setPrecision] = useState<Precision>(model.config.precision as Precision);
9494
const [useMaskRefinement, setUseMaskRefinement] = useState<boolean>(model.config.use_mask_refinement);
95-
const [compileModels, setCompileModels] = useState<boolean>(model.config.compile_models);
9695
const [useNMS, setUseNMS] = useState<boolean>(model.config.use_nms);
9796

9897
const updateModelMutation = useUpdateModel();
@@ -105,7 +104,6 @@ const MatcherConfiguration = ({ model, onClose }: MatcherConfigurationProps) =>
105104
decoderModel === model.config.sam_model &&
106105
precision === model.config.precision &&
107106
useMaskRefinement === model.config.use_mask_refinement &&
108-
compileModels === model.config.compile_models &&
109107
useNMS === model.config.use_nms;
110108

111109
const updateModel = (event: FormEvent) => {
@@ -124,7 +122,6 @@ const MatcherConfiguration = ({ model, onClose }: MatcherConfigurationProps) =>
124122
encoder_model: encoderModel,
125123
sam_model: decoderModel,
126124
use_mask_refinement: useMaskRefinement,
127-
compile_models: compileModels,
128125
use_nms: useNMS,
129126
precision,
130127
},
@@ -182,9 +179,6 @@ const MatcherConfiguration = ({ model, onClose }: MatcherConfigurationProps) =>
182179
<Switch isEmphasized isSelected={useNMS} onChange={setUseNMS}>
183180
Merge overlapping results
184181
</Switch>
185-
<Switch isEmphasized isSelected={compileModels} onChange={setCompileModels}>
186-
Optimise models
187-
</Switch>
188182
</Flex>
189183
<ButtonGroup align={'end'}>
190184
<Button variant={'secondary'} onPress={onClose}>
@@ -221,7 +215,6 @@ const PerDINOConfiguration = ({ model, onClose }: PerDINOConfigurationProps) =>
221215
const [encoderModel, setEncoderModel] = useState<EncoderModel>(model.config.encoder_model as EncoderModel);
222216
const [decoderModel, setDecoderModel] = useState<DecoderModel>(model.config.sam_model);
223217
const [precision, setPrecision] = useState<Precision>(model.config.precision as Precision);
224-
const [compileModels, setCompileModels] = useState<boolean>(model.config.compile_models);
225218
const [useNMS, setUseNMS] = useState<boolean>(model.config.use_nms);
226219
const [pointSelectionThreshold, setPointSelectionThreshold] = useState<number>(
227220
model.config.point_selection_threshold
@@ -238,7 +231,6 @@ const PerDINOConfiguration = ({ model, onClose }: PerDINOConfigurationProps) =>
238231
encoderModel === model.config.encoder_model &&
239232
decoderModel === model.config.sam_model &&
240233
precision === model.config.precision &&
241-
compileModels === model.config.compile_models &&
242234
useNMS === model.config.use_nms;
243235

244236
const updateModel = (event: FormEvent) => {
@@ -258,7 +250,6 @@ const PerDINOConfiguration = ({ model, onClose }: PerDINOConfigurationProps) =>
258250
point_selection_threshold: pointSelectionThreshold,
259251
encoder_model: encoderModel,
260252
sam_model: decoderModel,
261-
compile_models: compileModels,
262253
use_nms: useNMS,
263254
precision,
264255
},
@@ -329,9 +320,6 @@ const PerDINOConfiguration = ({ model, onClose }: PerDINOConfigurationProps) =>
329320
<Switch isEmphasized isSelected={useNMS} onChange={setUseNMS}>
330321
Merge overlapping results
331322
</Switch>
332-
<Switch isEmphasized isSelected={compileModels} onChange={setCompileModels}>
333-
Optimise models
334-
</Switch>
335323
</Flex>
336324
<ButtonGroup align={'end'}>
337325
<Button variant={'secondary'} onPress={onClose}>
@@ -367,7 +355,6 @@ const SoftMatcherConfiguration = ({ model, onClose }: SoftMatcherConfigurationPr
367355
const [encoderModel, setEncoderModel] = useState<EncoderModel>(model.config.encoder_model as EncoderModel);
368356
const [decoderModel, setDecoderModel] = useState<DecoderModel>(model.config.sam_model);
369357
const [precision, setPrecision] = useState<Precision>(model.config.precision as Precision);
370-
const [compileModels, setCompileModels] = useState<boolean>(model.config.compile_models);
371358
const [useNMS, setUseNMS] = useState<boolean>(model.config.use_nms);
372359
const [useSampling, setUseSampling] = useState<boolean>(model.config.use_sampling);
373360
const [useSpatialSampling, setUseSpatialSampling] = useState<boolean>(model.config.use_spatial_sampling);
@@ -388,7 +375,6 @@ const SoftMatcherConfiguration = ({ model, onClose }: SoftMatcherConfigurationPr
388375
encoderModel === model.config.encoder_model &&
389376
decoderModel === model.config.sam_model &&
390377
precision === model.config.precision &&
391-
compileModels === model.config.compile_models &&
392378
useNMS === model.config.use_nms &&
393379
useSampling === model.config.use_sampling &&
394380
useSpatialSampling === model.config.use_spatial_sampling &&
@@ -411,7 +397,6 @@ const SoftMatcherConfiguration = ({ model, onClose }: SoftMatcherConfigurationPr
411397
confidence_threshold: confidenceThreshold,
412398
encoder_model: encoderModel,
413399
sam_model: decoderModel,
414-
compile_models: compileModels,
415400
use_nms: useNMS,
416401
softmatching_bidirectional: softMatchingBidirectional,
417402
softmatching_score_threshold: softMatchingScoreThreshold,
@@ -482,9 +467,6 @@ const SoftMatcherConfiguration = ({ model, onClose }: SoftMatcherConfigurationPr
482467
<Switch isEmphasized isSelected={useNMS} onChange={setUseNMS}>
483468
Merge overlapping results
484469
</Switch>
485-
<Switch isEmphasized isSelected={compileModels} onChange={setCompileModels}>
486-
Optimise models
487-
</Switch>
488470
<Switch isEmphasized isSelected={approximateMatching} onChange={setApproximateMatching}>
489471
Approximate matching
490472
</Switch>

‎application/ui/src/features/prompts/models/model-toolbar/model-configuration/model-configuration-dialog.test.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,6 @@ describe('ModelConfigurationDialog', () => {
180180
encoder_model: 'dinov3_base',
181181
precision: precision.toLowerCase(),
182182
use_nms: model.config.use_nms,
183-
compile_models: model.config.compile_models,
184183
})
185184
);
186185
});

‎application/ui/src/setup-test.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ const MOCKED_MODELS_RESPONSE: ModelListType = {
8686
encoder_model: 'dinov3_large',
8787
use_mask_refinement: false,
8888
use_nms: false,
89-
compile_models: false,
9089
},
9190
active: true,
9291
name: 'Mega model',

‎application/ui/src/test-utils/mocks/mock-model.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export const getMockedModel = (model?: Partial<ModelType>): ModelType => {
1919
confidence_threshold: 0.42,
2020
precision: 'bf16',
2121
use_nms: true,
22-
compile_models: true,
2322
},
2423
active: true,
2524
name: 'PerDINO',

0 commit comments

Comments
 (0)