Fix: preserve local cluster domain filtering

rajsinghtech · rajsinghtech · commit 16bc17d191d5 · 2025-10-18T13:09:28.000-05:00
Pass dashboard domain filters to Homer config generator for single-cluster
mode. Multi-cluster HTTPRoutes use per-cluster filters from annotations.
diff --git a/internal/controller/dashboard_controller.go b/internal/controller/dashboard_controller.go
@@ -898,9 +898,9 @@ func (r *DashboardReconciler) createConfigMap(ctx context.Context, homerConfig *
 			}
 		}
 
-		// Don't pass domain filters since HTTPRoutes are already filtered by ClusterManager
-		// and we want to show all hostnames from each HTTPRoute
-		return homer.CreateConfigMapWithHTTPRoutes(homerConfig, dashboard.Name, dashboard.Namespace, filteredIngressList, filteredHTTPRoutes, dashboard, nil)
+		// Pass domain filters for single-cluster mode (local cluster uses dashboard-level filters)
+		// Multi-cluster HTTPRoutes already have domain filters stored in annotations
+		return homer.CreateConfigMapWithHTTPRoutes(homerConfig, dashboard.Name, dashboard.Namespace, filteredIngressList, filteredHTTPRoutes, dashboard, dashboard.Spec.DomainFilters)
 	}
 
 	return homer.CreateConfigMap(homerConfig, dashboard.Name, dashboard.Namespace, filteredIngressList, dashboard)

Original file line number	Diff line number	Diff line change
`@@ -898,9 +898,9 @@ func (r DashboardReconciler) createConfigMap(ctx context.Context, homerConfig `
`898`	`898`	`}`
`899`	`899`	`}`
`900`	`900`
`901`		`- // Don't pass domain filters since HTTPRoutes are already filtered by ClusterManager`
`902`		`- // and we want to show all hostnames from each HTTPRoute`
`903`		`- return homer.CreateConfigMapWithHTTPRoutes(homerConfig, dashboard.Name, dashboard.Namespace, filteredIngressList, filteredHTTPRoutes, dashboard, nil)`
	`901`	`+ // Pass domain filters for single-cluster mode (local cluster uses dashboard-level filters)`
	`902`	`+ // Multi-cluster HTTPRoutes already have domain filters stored in annotations`
	`903`	`+ return homer.CreateConfigMapWithHTTPRoutes(homerConfig, dashboard.Name, dashboard.Namespace, filteredIngressList, filteredHTTPRoutes, dashboard, dashboard.Spec.DomainFilters)`
`904`	`904`	`}`
`905`	`905`
`906`	`906`	`return homer.CreateConfigMap(homerConfig, dashboard.Name, dashboard.Namespace, filteredIngressList, dashboard)`