Remove unimplemented AdvancedConfig from CRD (fixes feedback from #29)

rajsinghtech · rajsinghtech · commit aa6a5254b3e3 · 2025-10-03T10:44:53.000-04:00
Removed placeholder features that were not actually implemented: - AdvancedConfig type with enableDependencyAnalysis, enableMetricsAggregation, enableLayoutOptimization - Advanced field from DashboardSpec - Advanced config from multicluster sample file - Related tests These were design placeholders with no actual implementation, causing confusion. Thanks to @gberche-orange for spotting this.
diff --git a/api/v1alpha1/dashboard_types.go b/api/v1alpha1/dashboard_types.go
@@ -80,9 +80,6 @@ type DashboardSpec struct {
 	// HealthCheck configures health checking for discovered services.
 	HealthCheck *ServiceHealthConfig `json:"healthCheck,omitempty"`
 
-	// Advanced configures advanced aggregation and analysis features.
-	Advanced *AdvancedConfig `json:"advanced,omitempty"`
-
 	// RemoteClusters configures discovery from additional Kubernetes clusters.
 	// When specified, the operator will connect to these clusters and discover
 	// Ingress/HTTPRoute resources from them in addition to the local cluster.
@@ -365,25 +362,3 @@ type ServiceHealthConfig struct {
 	// Headers to include in health check requests
 	Headers map[string]string `json:"headers,omitempty"`
 }
-
-// AdvancedConfig configures advanced aggregation and analysis features
-type AdvancedConfig struct {
-	// EnableDependencyAnalysis enables automatic service dependency detection
-	EnableDependencyAnalysis bool `json:"enableDependencyAnalysis,omitempty"`
-
-	// EnableMetricsAggregation enables service metrics collection and display
-	EnableMetricsAggregation bool `json:"enableMetricsAggregation,omitempty"`
-
-	// EnableLayoutOptimization enables automatic service layout optimization
-	EnableLayoutOptimization bool `json:"enableLayoutOptimization,omitempty"`
-
-	// MaxServicesPerGroup limits the number of services per group (0 = unlimited)
-	// +kubebuilder:validation:Minimum=0
-	// +kubebuilder:default=0
-	MaxServicesPerGroup int `json:"maxServicesPerGroup,omitempty"`
-
-	// MaxItemsPerService limits the number of items per service (0 = unlimited)
-	// +kubebuilder:validation:Minimum=0
-	// +kubebuilder:default=0
-	MaxItemsPerService int `json:"maxItemsPerService,omitempty"`
-}
diff --git a/api/v1alpha1/dashboard_types_test.go b/api/v1alpha1/dashboard_types_test.go
@@ -79,18 +79,11 @@ func TestDashboardSpecValidation(t *testing.T) {
 			hasError: false,
 		},
 		{
-			name: "Valid spec with advanced config",
+			name: "Valid spec with remote clusters",
 			spec: DashboardSpec{
 				HomerConfig: homer.HomerConfig{
 					Title: "Test Dashboard",
 				},
-				Advanced: &AdvancedConfig{
-					EnableDependencyAnalysis: true,
-					EnableMetricsAggregation: true,
-					EnableLayoutOptimization: true,
-					MaxServicesPerGroup:      10,
-					MaxItemsPerService:       20,
-				},
 			},
 			hasError: false,
 		},
@@ -120,13 +113,6 @@ func TestDashboardSpecValidation(t *testing.T) {
 					HealthPath:   "/api/health",
 					ExpectedCode: 200,
 				},
-				Advanced: &AdvancedConfig{
-					EnableDependencyAnalysis: true,
-					EnableMetricsAggregation: true,
-					EnableLayoutOptimization: true,
-					MaxServicesPerGroup:      15,
-					MaxItemsPerService:       25,
-				},
 				DomainFilters: []string{"example.com", "internal.local"},
 			},
 			hasError: false,
@@ -175,15 +161,6 @@ func TestDashboardSpecValidation(t *testing.T) {
 				}
 			}
 
-			// Validate advanced config
-			if dashboard.Spec.Advanced != nil {
-				ac := dashboard.Spec.Advanced
-				if ac.MaxServicesPerGroup < 0 || ac.MaxItemsPerService < 0 {
-					if !tt.hasError {
-						t.Error("Expected max values to be non-negative")
-					}
-				}
-			}
 		})
 	}
 }
@@ -313,25 +290,6 @@ func TestServiceHealthConfigValidation(t *testing.T) {
 	}
 }
 
-func TestAdvancedConfigDefaults(t *testing.T) {
-	config := &AdvancedConfig{}
-
-	// Check that default values work properly
-	if config.MaxServicesPerGroup < 0 {
-		t.Error("MaxServicesPerGroup should not be negative")
-	}
-
-	if config.MaxItemsPerService < 0 {
-		t.Error("MaxItemsPerService should not be negative")
-	}
-
-	// Test that zero values (unlimited) are valid
-	if config.MaxServicesPerGroup == 0 && config.MaxItemsPerService == 0 {
-		// This should be valid (unlimited) - test passes by not erroring
-		t.Log("Zero values are correctly treated as unlimited")
-	}
-}
-
 func TestDashboardCreation(t *testing.T) {
 	dashboard := &Dashboard{
 		ObjectMeta: metav1.ObjectMeta{
@@ -360,13 +318,6 @@ func TestDashboardCreation(t *testing.T) {
 					"Authorization": "Bearer health-token",
 				},
 			},
-			Advanced: &AdvancedConfig{
-				EnableDependencyAnalysis: true,
-				EnableMetricsAggregation: false,
-				EnableLayoutOptimization: true,
-				MaxServicesPerGroup:      12,
-				MaxItemsPerService:       30,
-			},
 		},
 	}
 
@@ -399,17 +350,6 @@ func TestDashboardCreation(t *testing.T) {
 		t.Errorf("Expected interval '45s', got '%s'", dashboard.Spec.HealthCheck.Interval)
 	}
 
-	if dashboard.Spec.Advanced.MaxServicesPerGroup != 12 {
-		t.Errorf("Expected max services per group 12, got %d", dashboard.Spec.Advanced.MaxServicesPerGroup)
-	}
-
-	if dashboard.Spec.Advanced.EnableDependencyAnalysis != true {
-		t.Error("Expected dependency analysis to be enabled")
-	}
-
-	if dashboard.Spec.Advanced.EnableMetricsAggregation != false {
-		t.Error("Expected metrics aggregation to be disabled")
-	}
 }
 
 // Helper function to create int32 pointer
diff --git a/api/v1alpha1/zz_generated.deepcopy.go b/api/v1alpha1/zz_generated.deepcopy.go
diff --git a/charts/homer-operator/templates/crd.yaml b/charts/homer-operator/templates/crd.yaml
@@ -61,35 +61,6 @@ spec:
           spec:
             description: DashboardSpec defines the desired state of Dashboard
             properties:
-              advanced:
-                description: Advanced configures advanced aggregation and analysis
-                  features.
-                properties:
-                  enableDependencyAnalysis:
-                    description: EnableDependencyAnalysis enables automatic service
-                      dependency detection
-                    type: boolean
-                  enableLayoutOptimization:
-                    description: EnableLayoutOptimization enables automatic service
-                      layout optimization
-                    type: boolean
-                  enableMetricsAggregation:
-                    description: EnableMetricsAggregation enables service metrics
-                      collection and display
-                    type: boolean
-                  maxItemsPerService:
-                    default: 0
-                    description: MaxItemsPerService limits the number of items per
-                      service (0 = unlimited)
-                    minimum: 0
-                    type: integer
-                  maxServicesPerGroup:
-                    default: 0
-                    description: MaxServicesPerGroup limits the number of services
-                      per group (0 = unlimited)
-                    minimum: 0
-                    type: integer
-                type: object
               assets:
                 description: Assets configures custom assets (logos, icons, CSS) for
                   the dashboard.
diff --git a/config/crd/bases/homer.rajsingh.info_dashboards.yaml b/config/crd/bases/homer.rajsingh.info_dashboards.yaml
@@ -55,35 +55,6 @@ spec:
           spec:
             description: DashboardSpec defines the desired state of Dashboard
             properties:
-              advanced:
-                description: Advanced configures advanced aggregation and analysis
-                  features.
-                properties:
-                  enableDependencyAnalysis:
-                    description: EnableDependencyAnalysis enables automatic service
-                      dependency detection
-                    type: boolean
-                  enableLayoutOptimization:
-                    description: EnableLayoutOptimization enables automatic service
-                      layout optimization
-                    type: boolean
-                  enableMetricsAggregation:
-                    description: EnableMetricsAggregation enables service metrics
-                      collection and display
-                    type: boolean
-                  maxItemsPerService:
-                    default: 0
-                    description: MaxItemsPerService limits the number of items per
-                      service (0 = unlimited)
-                    minimum: 0
-                    type: integer
-                  maxServicesPerGroup:
-                    default: 0
-                    description: MaxServicesPerGroup limits the number of services
-                      per group (0 = unlimited)
-                    minimum: 0
-                    type: integer
-                type: object
               assets:
                 description: Assets configures custom assets (logos, icons, CSS) for
                   the dashboard.
diff --git a/config/samples/homer_v1alpha1_dashboard_multicluster.yaml b/config/samples/homer_v1alpha1_dashboard_multicluster.yaml
@@ -185,13 +185,6 @@ spec:
       condition:
         "cluster": "production"
       priority: 1
-
-  # Advanced features
-  advanced:
-    enableDependencyAnalysis: true
-    enableMetricsAggregation: true
-    enableLayoutOptimization: true
-    maxServicesPerGroup: 50  # Higher limit for multi-cluster
 ---
 # Example Service Account and RBAC for remote cluster access
 # This should be created in each remote cluster
