Add optional cluster-name-suffix label support for remote clusters

- Remove ClusterNameSuffix field from Dashboard CRD spec
- Add support for cluster-name-suffix label in remoteClusters clusterLabels
- Suffix is only applied when label is set (opt-in behavior)
- Update config.go to read suffix from resource labels
- Simplify API by removing *WithSuffix functions
- Update tests to use label-based approach
- Update dashboard-shared.yaml to use cluster-name-suffix labels
- Update README documentation with new configuration format

This allows users to manually define custom suffixes per cluster
(e.g., ' (ottawa)', ' [prod]') without template interpolation.
If the label is not set, no suffix is added to service names.

Author: rajsinghtech

README.md

@@ -724,16 +724,33 @@ spec:
         - "api.example.com"      # API endpoints
 ```
 
-**Automatic Cluster Tagging:**
-Services from remote clusters automatically get badge tags with the cluster name. Customize colors using the `cluster-tagstyle` label:
+**Cluster Name Suffix:**
+Append custom suffixes to service display names to distinguish items from different clusters. Configure using the `cluster-name-suffix` label in `clusterLabels`:
+
+```yaml
+remoteClusters:
+  - name: ottawa
+    clusterLabels:
+      cluster-name-suffix: " (ottawa)"      # -> "Service Name (ottawa)"
+      # Other formats:
+      # " - ottawa"     -> "Service Name - ottawa"
+      # " [ottawa]"     -> "Service Name [ottawa]"
+```
+
+This suffix is only applied to items from **remote clusters**, not the local cluster. If the label is not set, no suffix is appended.
+
+**Automatic Cluster Tagging (Optional):**
+Services from remote clusters can also get badge tags with the cluster name when `cluster-tagstyle` is set in `clusterLabels`. Available colors:
 - `is-danger` (red) - production
 - `is-warning` (yellow) - staging
-- `is-info` (blue, default) - development
-- `is-success` (green) - QA
+- `is-info` (blue) - development
+- `is-success` (green) - QA/testing
 - `is-light` (gray) - deprecated
 
+**Important:** Tags are only added when `cluster-tagstyle` is explicitly configured. You can use both suffix and tags, or just one approach for cluster identification.
+
 **Per-Cluster Domain Filtering:**
-Each cluster can have independent `domainFilters` to control which services are discovered. If not specified, inherits from the main `spec.domainFilters`.
+Each cluster can have independent `domainFilters` to control which services are discovered. If not specified for a remote cluster, no domain filtering is applied (all resources pass through). Dashboard-level `spec.domainFilters` only applies to the local cluster.
 
 ### Status Monitoring
 

pkg/homer/cluster_tag_test.go

@@ -281,3 +281,155 @@ func TestClusterTagNotOverriddenByAnnotations(t *testing.T) {
 		t.Errorf("Expected manual tagstyle 'is-danger', got %q", tagstyle)
 	}
 }
+
+// TestClusterNameSuffix verifies that cluster name suffix is appended to item names from label
+func TestClusterNameSuffix(t *testing.T) {
+	tests := []struct {
+		name               string
+		clusterAnnot       string
+		clusterNameSuffix  string // stored in label
+		expectedNameSuffix string
+	}{
+		{
+			name:               "Remote cluster with suffix in parentheses",
+			clusterAnnot:       "ottawa",
+			clusterNameSuffix:  " (ottawa)",
+			expectedNameSuffix: " (ottawa)",
+		},
+		{
+			name:               "Remote cluster with dash suffix",
+			clusterAnnot:       "production",
+			clusterNameSuffix:  " - production",
+			expectedNameSuffix: " - production",
+		},
+		{
+			name:               "Remote cluster with bracket suffix",
+			clusterAnnot:       "staging",
+			clusterNameSuffix:  " [staging]",
+			expectedNameSuffix: " [staging]",
+		},
+		{
+			name:              "Remote cluster without suffix label",
+			clusterAnnot:      "ottawa",
+			clusterNameSuffix: "",
+		},
+		{
+			name:              "Local cluster with suffix label (should not apply)",
+			clusterAnnot:      "local",
+			clusterNameSuffix: " (local)",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			// Test with Ingress
+			ingress := &networkingv1.Ingress{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:        "test-ingress",
+					Namespace:   "default",
+					Annotations: map[string]string{},
+					Labels:      map[string]string{},
+				},
+				Spec: networkingv1.IngressSpec{
+					Rules: []networkingv1.IngressRule{
+						{Host: "test.example.com"},
+					},
+				},
+			}
+
+			if tt.clusterAnnot != "" {
+				ingress.ObjectMeta.Annotations["homer.rajsingh.info/cluster"] = tt.clusterAnnot
+			}
+
+			if tt.clusterNameSuffix != "" {
+				ingress.ObjectMeta.Labels["cluster-name-suffix"] = tt.clusterNameSuffix
+			}
+
+			config := &HomerConfig{
+				Title:  "Test Dashboard",
+				Header: true,
+			}
+
+			UpdateHomerConfigIngress(config, *ingress, nil)
+
+			if len(config.Services) == 0 {
+				t.Fatal("Expected at least one service")
+			}
+
+			service := config.Services[0]
+			if len(service.Items) == 0 {
+				t.Fatal("Expected at least one item")
+			}
+
+			item := service.Items[0]
+			itemName := item.Parameters["name"]
+			baseName := "test-ingress"
+
+			if tt.expectedNameSuffix != "" {
+				expectedName := baseName + tt.expectedNameSuffix
+				if itemName != expectedName {
+					t.Errorf("Expected name %q, got %q", expectedName, itemName)
+				}
+			} else {
+				// Should not have suffix
+				if itemName != baseName {
+					t.Errorf("Expected name %q without suffix, got %q", baseName, itemName)
+				}
+			}
+
+			// Test with HTTPRoute
+			hostname := gatewayv1.Hostname("test.example.com")
+			httproute := &gatewayv1.HTTPRoute{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:        "test-httproute",
+					Namespace:   "default",
+					Annotations: map[string]string{},
+					Labels:      map[string]string{},
+				},
+				Spec: gatewayv1.HTTPRouteSpec{
+					Hostnames: []gatewayv1.Hostname{hostname},
+				},
+			}
+
+			if tt.clusterAnnot != "" {
+				httproute.ObjectMeta.Annotations["homer.rajsingh.info/cluster"] = tt.clusterAnnot
+			}
+
+			if tt.clusterNameSuffix != "" {
+				httproute.ObjectMeta.Labels["cluster-name-suffix"] = tt.clusterNameSuffix
+			}
+
+			config2 := &HomerConfig{
+				Title:  "Test Dashboard",
+				Header: true,
+			}
+
+			UpdateHomerConfigHTTPRoute(config2, httproute, nil)
+
+			if len(config2.Services) == 0 {
+				t.Fatal("Expected at least one service")
+			}
+
+			service2 := config2.Services[0]
+			if len(service2.Items) == 0 {
+				t.Fatal("Expected at least one item")
+			}
+
+			item2 := service2.Items[0]
+			itemName2 := item2.Parameters["name"]
+			baseName2 := "test-httproute"
+
+			if tt.expectedNameSuffix != "" {
+				expectedName2 := baseName2 + tt.expectedNameSuffix
+				if itemName2 != expectedName2 {
+					t.Errorf("Expected HTTPRoute name %q, got %q", expectedName2, itemName2)
+				}
+			} else {
+				// Should not have suffix
+				if itemName2 != baseName2 {
+					t.Errorf("Expected HTTPRoute name %q without suffix, got %q", baseName2, itemName2)
+				}
+			}
+		})
+	}
+}

pkg/homer/config.go

@@ -1161,6 +1161,14 @@ func createIngressItem(ingress networkingv1.Ingress, host string, validRuleCount
 	if validRuleCount > 1 {
 		name = ingress.ObjectMeta.Name + "-" + host
 	}
+
+	// Append cluster name suffix from label if set (only for remote clusters)
+	if clusterName, ok := ingress.ObjectMeta.Annotations["homer.rajsingh.info/cluster"]; ok && clusterName != "" && clusterName != "local" {
+		if suffix, hasSuffix := ingress.ObjectMeta.Labels["cluster-name-suffix"]; hasSuffix && suffix != "" {
+			name = name + suffix
+		}
+	}
+
 	setItemParameter(&item, "name", name)
 	setItemParameter(&item, "logo", IngressIconURL)
 	setItemParameter(&item, "subtitle", host)
@@ -1276,6 +1284,14 @@ func updateHomerConfigWithHTTPRoutes(
 			if len(filteredHostnames) > 1 {
 				name = httproute.ObjectMeta.Name + "-" + hostStr
 			}
+
+			// Append cluster name suffix from label if set (only for remote clusters)
+			if clusterName, ok := httproute.ObjectMeta.Annotations["homer.rajsingh.info/cluster"]; ok && clusterName != "" && clusterName != "local" {
+				if suffix, hasSuffix := httproute.ObjectMeta.Labels["cluster-name-suffix"]; hasSuffix && suffix != "" {
+					name = name + suffix
+				}
+			}
+
 			setItemParameter(&item, "name", name)
 
 			// Set metadata for conflict detection