Skip to content

Commit 5414ca2

Browse files
committed
Fixed sha1/sockaddr_deleter.
1 parent ca5b42d commit 5414ca2

File tree

2 files changed

+5
-47
lines changed

2 files changed

+5
-47
lines changed

src/torrent/net/types.h

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,10 @@ namespace torrent {
1515
void sa_free(const sockaddr* sa) LIBTORRENT_EXPORT;
1616

1717
struct sockaddr_deleter {
18-
void operator()(const sockaddr* sa) {
19-
if (sa == nullptr)
20-
return;
18+
constexpr sockaddr_deleter() noexcept = default;
2119

22-
sa_free(sa);
23-
}
20+
// void operator()(sockaddr* sa) const { sa_free(sa); }
21+
void operator()(const sockaddr* sa) const { sa_free(sa); }
2422
};
2523

2624
using sa_unique_ptr = std::unique_ptr<sockaddr, sockaddr_deleter>;

src/utils/sha1.h

Lines changed: 2 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,16 @@
1-
// libTorrent - BitTorrent library
2-
// Copyright (C) 2005-2011, Jari Sundell
3-
//
4-
// This program is free software; you can redistribute it and/or modify
5-
// it under the terms of the GNU General Public License as published by
6-
// the Free Software Foundation; either version 2 of the License, or
7-
// (at your option) any later version.
8-
//
9-
// This program is distributed in the hope that it will be useful,
10-
// but WITHOUT ANY WARRANTY; without even the implied warranty of
11-
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12-
// GNU General Public License for more details.
13-
//
14-
// You should have received a copy of the GNU General Public License
15-
// along with this program; if not, write to the Free Software
16-
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
17-
//
18-
// In addition, as a special exception, the copyright holders give
19-
// permission to link the code of portions of this program with the
20-
// OpenSSL library under certain conditions as described in each
21-
// individual source file, and distribute linked combinations
22-
// including the two.
23-
//
24-
// You must obey the GNU General Public License in all respects for
25-
// all of the code used other than OpenSSL. If you modify file(s)
26-
// with this exception, you may extend this exception to your version
27-
// of the file(s), but you are not obligated to do so. If you do not
28-
// wish to do so, delete this exception statement from your version.
29-
// If you delete this exception statement from all source files in the
30-
// program, then also delete it here.
31-
//
32-
// Contact: Jari Sundell <jaris@ifi.uio.no>
33-
//
34-
// Skomakerveien 33
35-
// 3185 Skoppum, NORWAY
36-
371
#ifndef LIBTORRENT_HASH_COMPUTE_H
382
#define LIBTORRENT_HASH_COMPUTE_H
393

404
#include <cstring>
415
#include <memory>
42-
436
#include <openssl/evp.h>
447

458
namespace torrent {
469

4710
struct sha1_deleter {
48-
void operator()(EVP_MD_CTX* ctx) {
49-
if (ctx == nullptr)
50-
return;
11+
constexpr sha1_deleter() noexcept = default;
5112

52-
EVP_MD_CTX_free(ctx);
53-
}
13+
void operator()(const EVP_MD_CTX* ctx) const { EVP_MD_CTX_free(const_cast<EVP_MD_CTX*>(ctx)); }
5414
};
5515

5616
class Sha1 {

0 commit comments

Comments
 (0)