[Win32 UI Modernizer] Tasks stuck in Uninitializing after uninstall

[launcher-coder]

After uninstalling the Win32 UI Modernizer @crazyboyybs mod, Windhawk’s task manager shows multiple processes (e.g., dllhost.exe, StartMenuExperienceHost.exe, VSCodium.exe, ShellExperienceHost.exe) stuck in Uninitializing….

Reinstalling the mod also seem does not clear these tasks the previously stuck entries remain, while only the new installation task shows to be Succeeded

[m417z]

Looks like a deadlock around the code below.

The target window seems to be W32MThemeMsgWnd.

Two problems here:

• CreateMsgWindow is called in an arbitrary thread in Wh_ModInit. Nobody might be pumping messages, so this window isn't functional and can't respond to messages. It should be created in a dedicated thread instead.
• Removing subclasses in a broad way like this quite aggressive. A better way might be to keep track of the subclassed windows, and only unsubclass them.

// -- Subclass removal helpers --

static BOOL CALLBACK RemoveSubclassesFromWindow(HWND hwnd, LPARAM)
{
    RemoveCustomDarkModeFromWindow(hwnd);
    if (GetPropW(hwnd, PROP_TV_SUB)) {
        WindhawkUtils::RemoveWindowSubclassFromAnyThread(hwnd, TreeViewSubclass);
        RemovePropW(hwnd, PROP_TV_SUB);
        TreeInsertMarkClearProperties(hwnd);
    }
    TreeRuntimeRestoreStyleBit(hwnd, PROP_TV_HASLINES_ORIG, TVS_HASLINES);
    TreeRuntimeRestoreStyleBit(hwnd, PROP_TV_NOTOOLTIPS_ORIG, TVS_NOTOOLTIPS);
    // ================================================================================
    // Here:
    RemoveWindowSubclass(hwnd, StatusBarSubclassProc, 0);
    // ================================================================================
    RemoveWindowSubclass(hwnd, FontViewSubclassProc, kFontViewSubId);
    WindhawkUtils::RemoveWindowSubclassFromAnyThread(hwnd, TabSubclassProc);
    WindhawkUtils::RemoveWindowSubclassFromAnyThread(hwnd, CheckBoxSubclassProc);
    WindhawkUtils::RemoveWindowSubclassFromAnyThread(hwnd, PillTreeSubclassProc);
    return TRUE;
}

static BOOL CALLBACK EnumWindowsRemoveSubclasses(HWND hwnd, LPARAM)
{
    DWORD pid = 0;
    GetWindowThreadProcessId(hwnd, &pid);
    if (pid != GetCurrentProcessId()) return TRUE;
    RemoveSubclassesFromWindow(hwnd, 0);
    EnumChildWindows(hwnd, RemoveSubclassesFromWindow, 0);
    return TRUE;
}