Fix quote handling in JS

Author: rammpeter

CHANGELOG.md

@@ -1,7 +1,7 @@
 # Change log of Panorama for Oracle
 ## [Unreleased]
 
-## Relese 2.19.10
+## Relese 2.19.11
 - 2026-03-23 Run and show optimizer trace from SQL details page for SQLs from SGA
 
 ## Relese 2.19.9

app/controllers/dba_controller.rb

@@ -1868,7 +1868,7 @@ def show_trace_files
     render_partial
   end
 
-  # Generator a trace file of optimizer parse process
+  # Generate a trace file of optimizer parse process
   # The SQL must be in v$SQL of the current instance
   def optimizer_parse_trace
     @sql_id       = prepare_param :sql_id

app/helpers/application_helper.rb

@@ -557,7 +557,7 @@ def get_recall_params_info_for_render_page_caption
         :hint =>       t(:addition_copy_recall_params_hint, :default=>"Copy request parameter to clipboard which allows you to reconstruct/replay this page later\nCall menu &#39Spec. additions / Execute with given parameters&#39 and paste this info to reconstruct your page at later time."),
         :icon_class => 'cui-copy',
         show_icon_in_caption: true,
-        :action =>     "copy_to_clipboard('#{request.parameters.except(:update_area, :browser_tab_id).to_json.gsub("'", ''')}');  alert('#{t(:addition_copy_recall_params_answer, :default=>"Current request parameters are copied to clipboard.\nUse menu \"Spec. additions / Execute with given parameters\" to paste this parameters").gsub("\n", '\\n')}');"
+        :action =>     "copy_to_clipboard('#{request.parameters.except(:update_area, :browser_tab_id).to_json.gsub("'", ''').gsub('"', """)}');  show_popup_message('#{t(:addition_copy_recall_params_answer, :default=>"Current request parameters are copied to clipboard.\nUse menu \"Spec. additions / Execute with given parameters\" to paste this parameters").gsub("\n", '\\n').gsub('"', """)}');"
     }
   end
 
@@ -588,7 +588,11 @@ def sql_select_iterator(sql, modifier: nil, query_name: 'sql_select_iterator', c
     PanoramaConnection.sql_select_iterator(sql, modifier: modifier, query_name: query_name, convert_tz: convert_tz)
   end
 
-  # Select genau erste Zeile
+  # Select exactly the first line of a result
+  # @param [String, Array] sql The sql with optional bind parameters
+  # @param [String] query_name The name for log output
+  # @param [Boolean] convert_tz Should the time zone of date or time values be converted to the browser client timezone
+  # @return [Hash,nil]
   def sql_select_first_row(sql, query_name: 'sql_select_first_row', convert_tz: true)
     PanoramaConnection.sql_select_first_row(sql, query_name: query_name, convert_tz: convert_tz)
   end

config/application.rb

@@ -29,8 +29,8 @@
 
 module Panorama
   # VERSION and RELEASE_DATE should have fix syntax and positions because they are parsed from other sites
-  VERSION = '2.19.10'                                 if !defined? Panorama::VERSION
-  RELEASE_DATE = Date.parse('2026-03-27')         if !defined? Panorama::RELEASE_DATE
+  VERSION = '2.19.11'                                 if !defined? Panorama::VERSION
+  RELEASE_DATE = Date.parse('2026-03-29')         if !defined? Panorama::RELEASE_DATE
 
   RELEASE_DAY   = "%02d" % RELEASE_DATE.day           if !defined? Panorama::RELEASE_DAY
   RELEASE_MONTH = "%02d" % RELEASE_DATE.month         if !defined? Panorama::RELEASE_MONTH

test/controllers/dba_controller_test.rb

@@ -9,6 +9,13 @@ class DbaControllerTest < ActionDispatch::IntegrationTest
     #@routes = Engine.routes         # Suppress routing error if only routes for dummy application are active
     set_session_test_db_context
 
+    if !defined? @sga_sql_id
+      sql_row = sql_select_first_row "SELECT SQL_ID, Child_Number FROM v$sql WHERE SQL_Text LIKE '%seg$%' AND Object_Status = 'VALID' ORDER BY Executions DESC, First_Load_Time"
+      raise "DbaControllerTest.setup: No SQL found for test" if sql_row.nil?
+      @sga_sql_id = sql_row.sql_id
+      @sga_child_number = sql_row.child_number
+    end
+
     initialize_min_max_snap_id_and_times
     @autonomous = PanoramaConnection.autonomous_database?
   end
@@ -274,6 +281,26 @@ class DbaControllerTest < ActionDispatch::IntegrationTest
     end
   end
 
+  test "optimizer_parse_trace with xhr: true" do
+    assert_nothing_raised do
+      # DBMS_SQLDIAG.DUMP_TRACE requires Oracle >= 12.2 and access on gv$Diag_Trace_File_Contents
+      # Access on trace files is not possible on autonomous DBs
+      if get_db_version >= '12.2' && !PanoramaConnection.autonomous_database?
+        # Get a valid SQL-ID and child_number from the SGA
+        post '/dba/optimizer_parse_trace', params: { format:       :html,
+                                                     sql_id:       @sga_sql_id,
+                                                     child_number: @sga_child_number,
+                                                     update_area:  :hugo
+        }
+        if @response.body['ORA-01031']
+          Rails.logger.debug('DBAControllerTest.optimizer_parse_trace') { "No access to DBMS_SQLDIAG.DUMP_TRACE, cannot test optimizer_parse_trace" }
+        else
+          assert_response :success
+        end
+      end
+    end
+  end
+
   test "scheduler_autoruns with xhr: true" do
     post '/dba/list_dba_autotask_job_runs', :params => {format: :html, update_area: :hugo, client_name: 'auto optimizer stats collection' }
     assert_response :success

test/controllers/dba_sga_controller_test.rb

@@ -10,11 +10,12 @@ class DbaSgaControllerTest < ActionDispatch::IntegrationTest
 
     initialize_min_max_snap_id_and_times
 
-    if !defined? @@hist_sql_id
+    if !defined? @sga_sql_id
       sql_row = sql_select_first_row "SELECT SQL_ID, Child_Number, Parsing_Schema_Name FROM v$sql WHERE SQL_Text LIKE '%seg$%' AND Object_Status = 'VALID' ORDER BY Executions DESC, First_Load_Time"
-      @@hist_sql_id = sql_row.sql_id
-      @@sga_child_number = sql_row.child_number
-      @@hist_parsing_schema_name = sql_row.parsing_schema_name
+      raise "DbaSgaControllerTest.setup: No SQL found for test" if sql_row.nil?
+      @sga_sql_id = sql_row.sql_id
+      @sga_child_number = sql_row.child_number
+      @hist_parsing_schema_name = sql_row.parsing_schema_name
     end
     @instance = PanoramaConnection.instance_number
   end
@@ -80,15 +81,15 @@ def string2hex(s)
   end
 
   test "list_sql_detail_sql_id_childno with xhr: true" do
-    get '/dba_sga/list_sql_detail_sql_id_childno', :params => {:format=>:html, :instance => @instance, :sql_id => @@hist_sql_id, child_number: @@sga_child_number, :update_area=>:hugo  }
+    get '/dba_sga/list_sql_detail_sql_id_childno', :params => {:format=>:html, :instance => @instance, :sql_id => @sga_sql_id, child_number: @sga_child_number, :update_area=>:hugo  }
     assert_response :success
   end
 
   test "list_sql_detail_sql_id with xhr: true" do
-    get  '/dba_sga/list_sql_detail_sql_id' , :params => {:format=>:html, :instance =>@instance, :sql_id => @@hist_sql_id, :update_area=>:hugo }
+    get  '/dba_sga/list_sql_detail_sql_id' , :params => {:format=>:html, :instance =>@instance, :sql_id => @sga_sql_id, :update_area=>:hugo }
     assert_response :success
 
-    get  '/dba_sga/list_sql_detail_sql_id' , :params => {:format=>:html, :sql_id => @@hist_sql_id, :update_area=>:hugo }
+    get  '/dba_sga/list_sql_detail_sql_id' , :params => {:format=>:html, :sql_id => @sga_sql_id, :update_area=>:hugo }
     assert_response :success
 
     post '/dba_sga/list_sql_profile_detail', :params => {:format=>:html, :profile_name=>'Hugo', :update_area=>:hugo }
@@ -97,43 +98,43 @@ def string2hex(s)
   end
 
   test "list_sql_detail_execution_plan with xhr: true" do
-    post '/dba_sga/list_sql_detail_execution_plan' , params: {format: :html, instance: @instance, sql_id: @@hist_sql_id, update_area: :hugo }
+    post '/dba_sga/list_sql_detail_execution_plan' , params: {format: :html, instance: @instance, sql_id: @sga_sql_id, update_area: :hugo }
     assert_response :success
-    post '/dba_sga/list_sql_detail_execution_plan' , params: {format: :html, instance: @instance, sql_id: @@hist_sql_id, child_number: 1, child_address: 'ABC', update_area: :hugo }
+    post '/dba_sga/list_sql_detail_execution_plan' , params: {format: :html, instance: @instance, sql_id: @sga_sql_id, child_number: 1, child_address: 'ABC', update_area: :hugo }
     assert_response :success
   end
 
   test "list_sql_child_cursors with xhr: true" do
-    post '/dba_sga/list_sql_child_cursors' , params: {format: :html, instance: @instance, sql_id: @@hist_sql_id, update_area: :hugo }
+    post '/dba_sga/list_sql_child_cursors' , params: {format: :html, instance: @instance, sql_id: @sga_sql_id, update_area: :hugo }
     assert_response :success
   end
 
   test "list_bind_variables_per_sql with xhr: true" do
-    post '/dba_sga/list_bind_variables', :params => {format: :html, instance: @instance, sql_id: @@hist_sql_id, update_area: :hugo }
+    post '/dba_sga/list_bind_variables', :params => {format: :html, instance: @instance, sql_id: @sga_sql_id, update_area: :hugo }
     assert_response :success
 
-    post '/dba_sga/list_bind_variables', :params => {format: :html, instance: @instance, sql_id: @@hist_sql_id, child_number: 0, child_address: 'ABC', update_area: :hugo }
+    post '/dba_sga/list_bind_variables', :params => {format: :html, instance: @instance, sql_id: @sga_sql_id, child_number: 0, child_address: 'ABC', update_area: :hugo }
     assert_response :success
   end
 
 
   test "list_open_cursor_per_sql with xhr: true" do
-    get '/dba_sga/list_open_cursor_per_sql', :params => {:format=>:html, :instance=> @instance, :sql_id => @@hist_sql_id, :update_area=>:hugo }
+    get '/dba_sga/list_open_cursor_per_sql', :params => {:format=>:html, :instance=> @instance, :sql_id => @sga_sql_id, :update_area=>:hugo }
     assert_response :success
   end
 
   test "list_dbms_xplan_display with xhr: true" do
-    post '/dba_sga/list_dbms_xplan_display' , params: {format: :html, instance: @instance, sql_id: @@hist_sql_id, update_area: :hugo }
+    post '/dba_sga/list_dbms_xplan_display' , params: {format: :html, instance: @instance, sql_id: @sga_sql_id, update_area: :hugo }
     assert_response :success
   end
 
   test "list_dbms_xplan_display_multiple_children with xhr: true" do
-    post '/dba_sga/list_dbms_xplan_display_multiple_children' , params: {format: :html, instance: @instance, sql_id: @@hist_sql_id, update_area: :hugo }
+    post '/dba_sga/list_dbms_xplan_display_multiple_children' , params: {format: :html, instance: @instance, sql_id: @sga_sql_id, update_area: :hugo }
     assert_response :success
   end
 
   test "list_sql_shared_cursor with xhr: true" do
-    post '/dba_sga/list_sql_shared_cursor' , params: {format: :html, instance: @instance, sql_id: @@hist_sql_id, update_area: :hugo }
+    post '/dba_sga/list_sql_shared_cursor' , params: {format: :html, instance: @instance, sql_id: @sga_sql_id, update_area: :hugo }
     assert_response :success
   end
 
@@ -142,7 +143,7 @@ def string2hex(s)
       { child_number: nil,            show_defaults: true},
       { child_number: @child_number,  show_defaults: false}
     ].each do |v|
-      post '/dba_sga/list_sql_optimizer_env' , params: {format: :html, instance: @instance, sql_id: @@hist_sql_id, child_number: v[:child_number], show_defaults: v[:show_defaults], update_area: :hugo }
+      post '/dba_sga/list_sql_optimizer_env' , params: {format: :html, instance: @instance, sql_id: @sga_sql_id, child_number: v[:child_number], show_defaults: v[:show_defaults], update_area: :hugo }
       assert_response :success
     end
   end
@@ -193,12 +194,12 @@ def string2hex(s)
   end
 
   test "list_cursor_memory with xhr: true" do
-    get '/dba_sga/list_cursor_memory', :params => {:format=>:html, :instance=> @instance, :sql_id=>@@hist_sql_id, :update_area=>:hugo }
+    get '/dba_sga/list_cursor_memory', :params => {:format=>:html, :instance=> @instance, :sql_id=>@sga_sql_id, :update_area=>:hugo }
     assert_response :success
   end
 
   test "compare_execution_plans with xhr: true" do
-    post '/dba_sga/list_compare_execution_plans', :params => {:format=>:html, :instance_1=> @instance, :sql_id_1=>@@hist_sql_id, :child_number_1 =>@@sga_child_number, :instance_2=> @instance, :sql_id_2=>@@hist_sql_id, :child_number_2 =>@@sga_child_number, :update_area=>:hugo }
+    post '/dba_sga/list_compare_execution_plans', :params => {:format=>:html, :instance_1=> @instance, :sql_id_1=>@sga_sql_id, :child_number_1 =>@sga_child_number, :instance_2=> @instance, :sql_id_2=>@sga_sql_id, :child_number_2 =>@sga_child_number, :update_area=>:hugo }
     assert_response :success
   end
 
@@ -253,7 +254,7 @@ def string2hex(s)
     assert_response :success
 
     if get_db_version >= '12.1'
-      [nil, @@hist_sql_id].each do |translation_sql_id|
+      [nil, @sga_sql_id].each do |translation_sql_id|
         post '/dba_sga/show_sql_translations', :params => {:format=>:html, :translation_sql_id=>translation_sql_id, :update_area=>:hugo }
         assert_response :success
       end
@@ -267,7 +268,7 @@ def string2hex(s)
   end
 
   test "influence_sql_plan with xhr: true" do
-    post '/dba_sga/influence_sql_plan', :params => {:format=>:html, sql_id: @@hist_sql_id, :update_area=>:hugo }
+    post '/dba_sga/influence_sql_plan', :params => {:format=>:html, sql_id: @sga_sql_id, :update_area=>:hugo }
     assert_response :success
   end
 
@@ -278,8 +279,8 @@ def string2hex(s)
           [nil, true].each do |fixed_user|
             post '/dba_sga/show_sql_translations', :params => {:format      => :html,
                                                                :location    => location,
-                                                               :sql_id      => @@hist_sql_id,
-                                                               :user_name   => @@hist_parsing_schema_name,
+                                                               :sql_id      => @sga_sql_id,
+                                                               :user_name   => @hist_parsing_schema_name,
                                                                :fixed_user  => fixed_user,
                                                                :update_area => :hugo
             }
@@ -293,7 +294,7 @@ def string2hex(s)
   test "generate_sql_patch with xhr: true" do
     assert_nothing_raised do
       if get_db_version >= '12.1'
-        post '/dba_sga/generate_sql_patch', :params => {format: :html, sql_id: @@hist_sql_id, update_area: :hugo }
+        post '/dba_sga/generate_sql_patch', :params => {format: :html, sql_id: @sga_sql_id, update_area: :hugo }
         assert_response :success
       end
     end