Use gv$Parameter if gv$Systemparameter has empty value column (e.g. autonomous DB)

Author: rammpeter

app/controllers/dba_controller.rb

@@ -633,7 +633,7 @@ def oracle_parameter
                                         Display_Value,
                                         IsDefault,
                                         ISSES_MODIFIABLE, IsSys_Modifiable, IsInstance_Modifiable, IsModified, IsAdjusted, IsDeprecated, Update_Comment#{", IsBasic" if get_db_version >= '11.1'}#{", Con_ID" if get_db_version >= '12.1'}
-                                 FROM  gv$System_Parameter
+                                 FROM  #{PanoramaConnection.system_parameter_table}
                                 ) v ON v.Instance = i.Instance AND v.ID = i.ID+1
                )
         WHERE 1=1 #{where_string}
@@ -643,7 +643,7 @@ def oracle_parameter
     rescue Exception
       if @option.nil?
         @hint = "Access rights on tables X$KSPPI and X$KSPPSV are possibly missing!</br>
-  Therefore only documented parameters from GV$System_Parameter are shown.</br></br>
+  Therefore only documented parameters from #{PanoramaConnection.system_parameter_table} are shown.</br></br>
 
   Possible solution to show underscore parameters also: Execute the following as user 'SYS':</br>
   &nbsp;&nbsp;  create view X_$KSPPI as select * from X$KSPPI;</br>
@@ -667,7 +667,7 @@ def oracle_parameter
                        Display_Value,
                        IsDefault,
                        ISSES_MODIFIABLE, IsSys_Modifiable, IsInstance_Modifiable, IsModified, IsAdjusted, IsDeprecated, Update_Comment#{", IsBasic" if get_db_version >= '11.1'}#{", Con_ID" if get_db_version >= '12.1'}
-                 FROM  gv$System_Parameter
+                 FROM  #{PanoramaConnection.system_parameter_table}
                 )
         WHERE 1=1 #{where_string}
         ORDER BY Name, Instance"].concat(where_values)

app/controllers/dba_sga_controller.rb

@@ -839,12 +839,12 @@ def list_sga_components
     @sums.each do |s|
       s['parameter'] =
           case s.pool
-            when 'buffer_cache' then "db_block_buffers = #{ fn(sql_select_one(["SELECT Value FROM gv$System_Parameter WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'db_block_buffers']))}, db_cache_size = #{fn(sql_select_one(["SELECT Value FROM gv$System_Parameter WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'db_cache_size']))}"
-            when 'java pool'    then "java_pool_size = #{   fn(sql_select_one(["SELECT Value FROM gv$System_Parameter WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'java_pool_size']))}"
-            when 'large pool'   then "large_pool_size = #{  fn(sql_select_one(["SELECT Value FROM gv$System_Parameter WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'large_pool_size']))}"
-            when 'log_buffer'   then "log_buffer = #{       fn(sql_select_one(["SELECT Value FROM gv$System_Parameter WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'log_buffer']))}"
-            when 'shared pool'  then "shared_pool_size = #{ fn(sql_select_one(["SELECT Value FROM gv$System_Parameter WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'shared_pool_size']))}"
-            when 'streams pool' then "streams_pool_size = #{fn(sql_select_one(["SELECT Value FROM gv$System_Parameter WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'streams_pool_size']))}"
+            when 'buffer_cache' then "db_block_buffers = #{ fn(sql_select_one(["SELECT Value FROM #{PanoramaConnection.system_parameter_table} WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'db_block_buffers']))}, db_cache_size = #{fn(sql_select_one(["SELECT Value FROM #{PanoramaConnection.system_parameter_table} WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'db_cache_size']))}"
+            when 'java pool'    then "java_pool_size = #{   fn(sql_select_one(["SELECT Value FROM #{PanoramaConnection.system_parameter_table} WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'java_pool_size']))}"
+            when 'large pool'   then "large_pool_size = #{  fn(sql_select_one(["SELECT Value FROM #{PanoramaConnection.system_parameter_table} WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'large_pool_size']))}"
+            when 'log_buffer'   then "log_buffer = #{       fn(sql_select_one(["SELECT Value FROM #{PanoramaConnection.system_parameter_table} WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'log_buffer']))}"
+            when 'shared pool'  then "shared_pool_size = #{ fn(sql_select_one(["SELECT Value FROM #{PanoramaConnection.system_parameter_table} WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'shared_pool_size']))}"
+            when 'streams pool' then "streams_pool_size = #{fn(sql_select_one(["SELECT Value FROM #{PanoramaConnection.system_parameter_table} WHERE Inst_ID = ? AND Name = ?", s.inst_id, 'streams_pool_size']))}"
           end
 
     end
@@ -1192,7 +1192,7 @@ def list_result_cache_content
                   #{@instance ? " AND Inst_ID = ?" : ""}
                   GROUP BY Inst_ID
                  ) s
-          JOIN   gv$System_Parameter ms ON ms.Inst_ID = s.Inst_ID AND ms.Name = 'result_cache_max_size'
+          JOIN   #{PanoramaConnection.system_parameter_table} ms ON ms.Inst_ID = s.Inst_ID AND ms.Name = 'result_cache_max_size'
           ", @instance]
 
     @usage = sql_select_all ["\

app/controllers/env_controller.rb

@@ -172,15 +172,15 @@ def start_page
 
 
       system_parameter_sql = if  get_db_version >= '12.1'
-                               # Ensure uniqueness of parameter names, because GV$System_Parameter may contain parameter names for each container
+                               # Ensure uniqueness of parameter names, because #{PanoramaConnection.system_parameter_table} may contain parameter names for each container
                                # Use the parameter of the current container if exists, otherwise use the parameter of the CDB (0)
-                               "SELECT Inst_ID, Name, Value FROM GV$System_Parameter p0
+                               "SELECT Inst_ID, Name, Value FROM #{PanoramaConnection.system_parameter_table} p0
                                 WHERE Con_ID = 0
-                                AND   NOT EXISTS (SELECT 1 FROM GV$System_Parameter pi WHERE pi.Inst_ID = p0.Inst_ID AND pi.Name = p0.Name AND pi.Con_ID = SYS_CONTEXT('USERENV', 'CON_ID'))
+                                AND   NOT EXISTS (SELECT 1 FROM #{PanoramaConnection.system_parameter_table} pi WHERE pi.Inst_ID = p0.Inst_ID AND pi.Name = p0.Name AND pi.Con_ID = SYS_CONTEXT('USERENV', 'CON_ID'))
                                 UNION ALL
-                                SELECT Inst_ID, Name, Value FROM GV$System_Parameter WHERE Con_ID = SYS_CONTEXT('USERENV', 'CON_ID')"
+                                SELECT Inst_ID, Name, Value FROM #{PanoramaConnection.system_parameter_table} WHERE Con_ID = SYS_CONTEXT('USERENV', 'CON_ID')"
                              else
-                               "SELECT Inst_ID, Name, Value FROM GV$System_Parameter"
+                               "SELECT Inst_ID, Name, Value FROM #{PanoramaConnection.system_parameter_table}"
                              end
       nls_parameters_sql = if  get_db_version >= '12.1'
                              "SELECT Inst_ID, Parameter, Value FROM gv$NLS_Parameters p0
@@ -735,7 +735,7 @@ def init_management_pack_license
 
   # @return [String] NONE | DIAGNOSTIC | DIAGNOSTIC+TUNING
   def read_control_management_pack_access
-    pack = sql_select_one "SELECT Value FROM V$System_Parameter WHERE name='control_management_pack_access'"
+    pack = sql_select_one "SELECT Value FROM #{PanoramaConnection.system_parameter_table[1..-1]} WHERE name='control_management_pack_access'"
     if pack.nil?
       if PanoramaConnection.autonomous_database?
         pack = 'DIAGNOSTIC+TUNING' # 'control_management_pack_access' is not set in autonomous databases, but license is included

app/controllers/storage_controller.rb

@@ -64,7 +64,7 @@ def storage_usage_totals
       AND    lf.Is_Recovery_Dest_File = 'NO'  /* Count only redo logs outside FRA separate */
       "
 
-    @fra_size_bytes = sql_select_one("SELECT Value FROM v$System_Parameter WHERE Name='db_recovery_file_dest_size'").to_i
+    @fra_size_bytes = sql_select_one("SELECT Value FROM #{PanoramaConnection.system_parameter_table[1..-1]} WHERE Name='db_recovery_file_dest_size'").to_i
     #@flashback_log = sql_select_first_row "SELECT * FROM v$Flashback_Database_Log"
     @fra_usage = sql_select_all "SELECT * FROM v$Flash_Recovery_Area_Usage WHERE Percent_Space_Used > 0 ORDER BY Percent_Space_Used DESC"
 
@@ -668,14 +668,14 @@ def undo_usage
              SUM(DECODE(Status, 'UNEXPIRED', Bytes, 0))/(1024*1024) Size_MB_UnExpired,
              SUM(DECODE(Status, 'EXPIRED',   Bytes, 0))/(1024*1024) Size_MB_Expired,
              SUM(DECODE(Status, 'ACTIVE',    Bytes, 0))/(1024*1024) Size_MB_Active,
-             (SELECT Inst_ID FROM gv$System_Parameter p WHERE Name='undo_tablespace' AND p.Value = e.Tablespace_Name) Inst_ID
+             (SELECT Inst_ID FROM #{PanoramaConnection.system_parameter_table} p WHERE Name='undo_tablespace' AND p.Value = e.Tablespace_Name) Inst_ID
       FROM   DBA_UNDO_Extents e
       GROUP BY Owner, Tablespace_Name
       ORDER BY SUM(Bytes) DESC")
 
     @undo_segments = sql_select_iterator("\
       SELECT /* Panorama-Tool Ramm */ r.*, i.Owner Extent_Owner, i.Size_MB, i.Size_MB_UnExpired, i.Size_MB_Expired, i.Size_MB_Active, t.Transactions
-             --,(SELECT Inst_ID FROM gv$System_Parameter p WHERE Name='undo_tablespace' AND p.Value = i.Tablespace_Name) Inst_ID
+             --,(SELECT Inst_ID FROM #{PanoramaConnection.system_parameter_table} p WHERE Name='undo_tablespace' AND p.Value = i.Tablespace_Name) Inst_ID
       FROM   DBA_Rollback_Segs r
       LEFT OUTER JOIN (SELECT Owner, Segment_Name, Tablespace_Name,
                               SUM(Bytes)/(1024*1024) Size_MB,

app/helpers/dragnet/dragnet_sqls_tuning_sga_pga_helper.rb

@@ -211,10 +211,10 @@ def dragnet_sqls_tuning_sga_pga
             :desc  => t(:dragnet_helper_3_12_desc, :default=> 'Detection of non-optimal or incompatible database parameters'),
             :sql=>  "SELECT /* DB-Tools Ramm DB-Parameter */
                              Inst_ID, Name, Value, 'Value should be 0 if cursor_sharing is used because lookup to session cached cursors is done before converting literals to bind variables' Description
-                      FROM   gv$System_Parameter p
+                      FROM   #{PanoramaConnection.system_parameter_table} p
                       WHERE  Name = 'session_cached_cursors'
                       AND    Value != '0'
-                      AND    EXISTS (SELECT 1 FROM gv$System_Parameter pi WHERE pi.Inst_ID=p.Inst_ID AND pi.Name='cursor_sharing' AND pi.value!='EXACT' )
+                      AND    EXISTS (SELECT 1 FROM #{PanoramaConnection.system_parameter_table} pi WHERE pi.Inst_ID=p.Inst_ID AND pi.Name='cursor_sharing' AND pi.value!='EXACT' )
                      ",
         },
     ]

app/helpers/panorama_sampler/package_panorama_sampler_snapshot.rb

@@ -266,7 +266,7 @@ def panorama_sampler_snapshot_code
     INSERT INTO panorama_owner.Panorama_Parameter (SNAP_ID, DBID, INSTANCE_NUMBER, PARAMETER_HASH, PARAMETER_NAME, VALUE, ISDEFAULT, ISMODIFIED, CON_DBID, CON_ID
     ) SELECT p_Snap_ID, p_DBID, p_Instance, Hash, Name, Value, ISDEFAULT, ISMODIFIED,
              #{PanoramaConnection.db_version >= '12.1' ? "panorama_owner.Con_DBID_From_Con_ID.Get(Con_ID), Con_ID" : "p_DBID, 0"}
-      FROM   v$System_Parameter
+      FROM   #{PanoramaConnection.system_parameter_table[1..-1]}
     ;
     COMMIT;
   END Snap_Parameter;

app/models/panorama_connection.rb

@@ -181,8 +181,8 @@ def read_initial_attributes
     db_config   = PanoramaConnection.direct_select_one(@jdbc_connection,
                   "SELECT i.Instance_Number, i.Version, d.DBID, d.Name Database_Name, SYS_CONTEXT('USERENV', 'SID') SID, v.Edition,
                           CASE WHEN d.Platform_Name LIKE '%64%' THEN 8 ELSE 4 END                                                              db_wordsize,
-                          NVL((SELECT /*+ NO_MERGE */ TO_NUMBER(Value) FROM v$System_Parameter WHERE Name = 'db_block_size'), 8192)       db_blocksize,
-                          NVL((SELECT /*+ NO_MERGE */ Value FROM v$System_Parameter WHERE Name = 'cluster_database'), 'FALSE')            cluster_database,
+                          NVL((SELECT /*+ NO_MERGE */ TO_NUMBER(Value) FROM #{system_parameter_table[1..-1]} WHERE Name = 'db_block_size'), 8192)       db_blocksize,
+                          NVL((SELECT /*+ NO_MERGE */ Value FROM #{system_parameter_table[1..-1]} WHERE Name = 'cluster_database'), 'FALSE')            cluster_database,
                           (SELECT Type_Size FROM v$Type_Size WHERE Type = 'KCBH')                                                         Block_Common_Header_Size,
                           (SELECT Type_Size FROM v$Type_Size WHERE Type = 'UB4')                                                          Unsigned_Byte_4_Size,
                           (SELECT Type_Size FROM v$Type_Size WHERE Type = 'KTBBH')                                                        Transaction_Fixed_Header_Size,
@@ -286,6 +286,17 @@ def autonomous_database?
     @autonomous_database
   end
 
+  # @return [String] the name of the system parameter table to use
+  def system_parameter_table
+    if !defined?(@system_parameter_table) || @system_parameter_table.nil?
+      @system_parameter_table = 'GV$System_Parameter'                           # Default if no other need
+      if PanoramaConnection.direct_select_one(@jdbc_connection, "SELECT Value FROM v$System_Parameter WHERE Name = 'cpu_count'")['value'].nil?
+        @system_parameter_table = 'GV$Parameter'                                # Use gv$Parameter if v$System_Parameter has empty values (e.g. for autonomous DB)
+      end
+    end
+    @system_parameter_table
+  end
+
   # Select PDBs each time they are requested because number of PDBs may change during lifetime of PanoramaConnection
   def pdbs
     if !defined?(@pdbs) || @pdbs.nil?
@@ -444,6 +455,7 @@ def self.rowid_size;                      check_for_open_connection;        Thre
   def self.saddr;                           check_for_open_connection;        Thread.current[:panorama_connection_connection_object].saddr;                             end
   def self.serial_no;                       check_for_open_connection;        Thread.current[:panorama_connection_connection_object].serial_no;                         end
   def self.sid;                             check_for_open_connection;        Thread.current[:panorama_connection_connection_object].sid;                               end
+  def self.system_parameter_table;          check_for_open_connection;        Thread.current[:panorama_connection_connection_object].system_parameter_table;            end
   # @return [Time] Time on DB-Server in his default timezone, but flagged with the time zone of the Panorama server
   def self.db_systime;                      check_for_open_connection;        Time.now + Thread.current[:panorama_connection_connection_object].time_delay_secs;        end
   def self.stat_id_consistent_gets;         check_for_open_connection;        Thread.current[:panorama_connection_connection_object].stat_id_consistent_gets;           end

app/views/env/_start_page.html.erb

@@ -131,9 +131,9 @@
           {:caption=>"Startup",       :data=>proc{|rec| localeDateTime(rec.startup_time) },   :title=>"Startup der DB" },
           {:caption=>"Archiver",      :data=>proc{|rec| rec.archiver },                       :title=>"Archiver mode of instance"},
           {:caption=>"Character-set", :data=>proc{|rec| rec.nls_characterset },               :title=>"Character set of database", :data_title=>proc{|rec| "%t: NChar_Character_Set=#{rec.nls_nchar_characterset}"}},
-          {:caption=>"Cp.",           :data=>show_compatible,                                 :title=>"Optimizer compatible mode of instance (from v$System_Parameter)", data_title: data_title_compatible},
+          {:caption=>"Cp.",           :data=>show_compatible,                                 :title=>"Optimizer compatible mode of instance (from #{PanoramaConnection.system_parameter_table[1..-1]})", data_title: data_title_compatible},
           {:caption=>"Instance role", :data=>proc{|rec| rec["instance_role"] },               :title=>"Instance role for data guard"},
-          {:caption=>"CPU cnt.",      :data=>proc{|rec| rec.cpu_count },                      :title=>"Number of CPUs counted for instance (from gv$System_Parameter)", data_title: cpu_count_data_title, align: :right},
+          {:caption=>"CPU cnt.",      :data=>proc{|rec| rec.cpu_count },                      :title=>"Number of CPUs counted for instance (from #{PanoramaConnection.system_parameter_table})", data_title: cpu_count_data_title, align: :right},
           {:caption=>"Phys. memory (GB)", :data=>proc{|rec| fn(rec.phys_mem_gb, 3) },         :title=>"Physical server memory in Gigabyte (from gv$OSStat)", data_title: phys_mem_data_title, align: :right},
           {:caption=>"Resource manager plan", :data=>proc{|rec| rec.resource_manager_plan },  :title=>"Resource manager plan that is currently active.\nEmpty if resource manager is deactivated."},
           {:caption=>"Srv.",          :data=>link_services,                                   :title=>"Number of TNS services for this instance\n(from gv$Services)", :align=>:right},