Skip to content

Commit 75d47b3

Browse files
authored
fix: phpstan issues described in #63 (#64)
* fix: phpstan issues described in #63 * fix: avoid psalm false-positive
1 parent a1ae3e8 commit 75d47b3

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/ConventionalCommits/Configuration/Configuration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
* A configuration provides additional rules on top of the Conventional
3030
* Commits specification
3131
*
32-
* @psalm-type ConfigurationOptionsType = array{typeCase?: string | null, types?: string[], scopeRequired?: bool, scopeCase?: string | null, scopes?: string[], descriptionCase?: string | null, descriptionEndMark?: string | null, bodyRequired?: bool, bodyWrapWidth?: int | null, requiredFooters?: string[]}
32+
* @psalm-type ConfigurationOptionsType = array{typeCase?: string | null, types?: string[], scopeCase?: string | null, scopeRequired?: bool, scopes?: string[], descriptionCase?: string | null, descriptionEndMark?: string | null, bodyRequired?: bool, bodyWrapWidth?: int | null, requiredFooters?: string[]}
3333
*/
3434
interface Configuration extends JsonSerializable
3535
{

src/ConventionalCommits/Configuration/DefaultConfiguration.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,9 @@ public function __construct(array $options = [])
8484
$this->bodyRequired = $options['bodyRequired'] ?? false;
8585
$this->requiredFooters = $this->requiredFootersIfValid($options['requiredFooters'] ?? []);
8686

87-
if (is_int($options['bodyWrapWidth'] ?? null)) {
88-
$this->bodyWrapWidth = $options['bodyWrapWidth'] ?? null;
87+
$bodyWrapWidth = $options['bodyWrapWidth'] ?? null;
88+
if (is_int($bodyWrapWidth)) {
89+
$this->bodyWrapWidth = $bodyWrapWidth;
8990
}
9091
}
9192

0 commit comments

Comments
 (0)