feature: move idempotency to logic function (#731)

Author: ran-isenberg

package-lock.json

@@ -1,5 +1,5 @@
 {
     "dependencies": {
-        "aws-cdk": "^2.93.0"
+        "aws-cdk": "^2.95.0"
     }
 }

package.json

@@ -4,7 +4,6 @@
 from aws_lambda_env_modeler import get_environment_variables, init_environment_variables
 from aws_lambda_powertools.metrics import MetricUnit
 from aws_lambda_powertools.utilities.feature_flags.exceptions import ConfigurationStoreError, SchemaValidationError
-from aws_lambda_powertools.utilities.idempotency import idempotent
 from aws_lambda_powertools.utilities.parser import ValidationError, parse
 from aws_lambda_powertools.utilities.parser.envelopes import ApiGatewayEnvelope
 from aws_lambda_powertools.utilities.typing import LambdaContext
@@ -13,7 +12,6 @@
 from service.handlers.schemas.env_vars import MyHandlerEnvVars
 from service.handlers.utils.dynamic_configuration import parse_configuration
 from service.handlers.utils.http_responses import build_response
-from service.handlers.utils.idempotency import IDEMPOTENCY_CONFIG, IDEMPOTENCY_LAYER
 from service.handlers.utils.observability import logger, metrics, tracer
 from service.logic.handle_create_request import handle_create_request
 from service.schemas.exceptions import InternalServerException
@@ -23,7 +21,6 @@
 
 @init_environment_variables(model=MyHandlerEnvVars)
 @metrics.log_metrics
-@idempotent(persistence_store=IDEMPOTENCY_LAYER, config=IDEMPOTENCY_CONFIG)
 @tracer.capture_lambda_handler(capture_response=False)
 def create_order(event: Dict[str, Any], context: LambdaContext) -> Dict[str, Any]:
     logger.set_correlation_id(context.aws_request_id)
@@ -51,6 +48,7 @@ def create_order(event: Dict[str, Any], context: LambdaContext) -> Dict[str, Any
         response: CreateOrderOutput = handle_create_request(
             order_request=create_input,
             table_name=env_vars.TABLE_NAME,
+            context=context,
         )
     except InternalServerException:  # pragma: no cover
         logger.error('finished handling create order request with internal error')

poetry.lock

@@ -1,15 +1,28 @@
+from aws_lambda_powertools.utilities.idempotency import idempotent_function
+from aws_lambda_powertools.utilities.idempotency.serialization.pydantic import PydanticSerializer
+from aws_lambda_powertools.utilities.typing import LambdaContext
+
 from service.dal.db_handler import DalHandler
 from service.dal.dynamo_dal_handler import get_dal_handler
 from service.dal.schemas.db import OrderEntry
 from service.handlers.schemas.dynamic_configuration import FeatureFlagsNames
 from service.handlers.utils.dynamic_configuration import get_dynamic_configuration_store
 from service.handlers.utils.observability import logger, tracer
+from service.logic.utils.idempotency import IDEMPOTENCY_CONFIG, IDEMPOTENCY_LAYER
 from service.schemas.input import CreateOrderRequest
 from service.schemas.output import CreateOrderOutput
 
 
+@idempotent_function(
+    data_keyword_argument='order_request',
+    config=IDEMPOTENCY_CONFIG,
+    persistence_store=IDEMPOTENCY_LAYER,
+    output_serializer=PydanticSerializer,
+)
 @tracer.capture_method(capture_response=False)
-def handle_create_request(order_request: CreateOrderRequest, table_name: str) -> CreateOrderOutput:
+def handle_create_request(order_request: CreateOrderRequest, table_name: str, context: LambdaContext) -> CreateOrderOutput:
+    IDEMPOTENCY_CONFIG.register_lambda_context(context)  # see Lambda timeouts section
+
     logger.info('starting to handle create request', extra={
         'order_item_count': order_request.order_item_count,
         'customer_name': order_request.customer_name

service/handlers/create_order.py

@@ -6,5 +6,4 @@
 IDEMPOTENCY_LAYER = DynamoDBPersistenceLayer(table_name=get_environment_variables(model=Idempotency).IDEMPOTENCY_TABLE_NAME)
 IDEMPOTENCY_CONFIG = IdempotencyConfig(
     expires_after_seconds=5 * 60,  # 5 minutes
-    event_key_jmespath='powertools_json(body).[customer_name, order_item_count]',
 )