Fix tests and a typo

Author: ValueRaider

tests/test_cache.py

@@ -8,8 +8,6 @@
    python -m unittest tests.cache.TestCache
 
 """
-from unittest import TestSuite
-
 from tests.context import yfinance as yf
 
 import unittest
@@ -48,46 +46,5 @@ def test_setTzCacheLocation(self):
         self.assertTrue(os.path.exists(os.path.join(self.tempCacheDir.name, "tkr-tz.db")))
 
 
-class TestCacheNoPermission(unittest.TestCase):
-    @classmethod
-    def setUpClass(cls):
-        if os.name == "nt":  # Windows
-            cls.cache_path = "C:\\Windows\\System32\\yf-cache"
-        else:  # Unix/Linux/MacOS
-            # Use a writable directory
-            cls.cache_path = "/yf-cache"
-        yf.set_tz_cache_location(cls.cache_path)
-
-    def test_tzCacheRootStore(self):
-        # Test that if cache path in read-only filesystem, no exception.
-        tkr = 'AMZN'
-        tz1 = "America/New_York"
-
-        # During attempt to store, will discover cannot write
-        yf.cache.get_tz_cache().store(tkr, tz1)
-
-        # Handling the store failure replaces cache with a dummy
-        cache = yf.cache.get_tz_cache()
-        self.assertTrue(cache.dummy)
-        cache.store(tkr, tz1)
-
-    def test_tzCacheRootLookup(self):
-        # Test that if cache path in read-only filesystem, no exception.
-        tkr = 'AMZN'
-        # During attempt to lookup, will discover cannot write
-        yf.cache.get_tz_cache().lookup(tkr)
-
-        # Handling the lookup failure replaces cache with a dummy
-        cache = yf.cache.get_tz_cache()
-        self.assertTrue(cache.dummy)
-        cache.lookup(tkr)
-
-def suite():
-    ts: TestSuite = unittest.TestSuite()
-    ts.addTest(TestCache('Test cache'))
-    ts.addTest(TestCacheNoPermission('Test cache no permission'))
-    return ts
-
-
 if __name__ == '__main__':
     unittest.main()

tests/test_cache_noperms.py

@@ -0,0 +1,52 @@
+"""
+Tests for cache
+
+To run all tests in suite from commandline:
+   python -m unittest tests.cache
+
+Specific test class:
+   python -m unittest tests.cache.TestCache
+
+"""
+from tests.context import yfinance as yf
+
+import unittest
+import os
+
+
+class TestCacheNoPermission(unittest.TestCase):
+    @classmethod
+    def setUpClass(cls):
+        if os.name == "nt":  # Windows
+            cls.cache_path = "C:\\Windows\\System32\\yf-cache"
+        else:  # Unix/Linux/MacOS
+            # Use a writable directory
+            cls.cache_path = "/yf-cache"
+        yf.set_tz_cache_location(cls.cache_path)
+
+    def test_tzCacheRootStore(self):
+        # Test that if cache path in read-only filesystem, no exception.
+        tkr = 'AMZN'
+        tz1 = "America/New_York"
+
+        # During attempt to store, will discover cannot write
+        yf.cache.get_tz_cache().store(tkr, tz1)
+
+        # Handling the store failure replaces cache with a dummy
+        cache = yf.cache.get_tz_cache()
+        self.assertTrue(cache.dummy)
+        cache.store(tkr, tz1)
+
+    def test_tzCacheRootLookup(self):
+        # Test that if cache path in read-only filesystem, no exception.
+        tkr = 'AMZN'
+        # During attempt to lookup, will discover cannot write
+        yf.cache.get_tz_cache().lookup(tkr)
+
+        # Handling the lookup failure replaces cache with a dummy
+        cache = yf.cache.get_tz_cache()
+        self.assertTrue(cache.dummy)
+        cache.lookup(tkr)
+
+if __name__ == '__main__':
+    unittest.main()

tests/test_ticker.py

@@ -1034,7 +1034,7 @@ def test_isin_info(self):
     def test_empty_info(self):
         # Test issue 2343 (Empty result _fetch)
         data = self.tickers[10].info
-        self.assertCountEqual(["trailingPegRatio"], data.keys())
+        self.assertCountEqual(['quoteType', 'symbol', 'underlyingSymbol', 'uuid', 'maxAge', 'trailingPegRatio'], data.keys())
         self.assertIn("trailingPegRatio", data.keys(), "Did not find expected key 'trailingPegRatio' in info dict")
 
         # Test issue 2363 (Empty QuoteResponse)

yfinance/lookup.py

@@ -24,7 +24,7 @@
 import pandas as pd
 
 from . import utils
-from .const import _QUERY1_URL_
+from .const import _QUERY1_URL_, _SENTINEL_
 from .data import YfData
 from .exceptions import YFException
 
@@ -44,15 +44,19 @@ class Lookup:
     """
 
     def __init__(self, query: str, session=None, proxy=None, timeout=30, raise_errors=True):
+        self.session = session
+        self._data = YfData(session=self.session)
+
+        if proxy is not _SENTINEL_:
+            utils.print_once("YF deprecation warning: set proxy via new config function: yf.set_proxy(proxy)")
+            self._data._set_proxy(proxy)
+
         self.query = query
 
-        self.session = session
-        self.proxy = proxy
         self.timeout = timeout
         self.raise_errors = raise_errors
 
         self._logger = utils.get_yf_logger()
-        self._data = YfData(session=self.session)
 
         self._cache = {}
 
@@ -75,7 +79,7 @@ def _fetch_lookup(self, lookup_type="all", count=25) -> dict:
 
         self._logger.debug(f'GET Lookup for ticker ({self.query}) with parameters: {str(dict(params))}')
 
-        data = self._data.get(url=url, params=params, proxy=self.proxy, timeout=self.timeout)
+        data = self._data.get(url=url, params=params, timeout=self.timeout)
         if data is None or "Will be right back" in data.text:
             raise RuntimeError("*** YAHOO! FINANCE IS CURRENTLY DOWN! ***\n"
                                "Our engineers are working quickly to resolve "

yfinance/scrapers/history.py

@@ -386,7 +386,7 @@ def history(self, period="1mo", interval="1d",
             msg = f'{self.ticker}: OHLC after combining events: {df.index[0]} -> {df.index[-1]}'
         logger.debug(msg)
 
-        df, last_trade = utils.fix_Yahoo_returning_live_separate(df, params["interval"], tz_exchange, repair=repair, currency=currency)
+        df, last_trade = utils.fix_Yahoo_returning_live_separate(df, params["interval"], tz_exchange, prepost, repair=repair, currency=currency)
         if last_trade is not None:
             self._history_metadata['lastTrade'] = {'Price':last_trade['Close'], "Time":last_trade.name}
 

yfinance/search.py

@@ -48,6 +48,9 @@ def __init__(self, query, max_results=8, news_count=8, lists_count=8, include_cb
             timeout: Request timeout in seconds (default 30).
             raise_errors: Raise exceptions on error (default True).
         """
+        self.session = session
+        self._data = YfData(session=self.session)
+        
         if proxy is not _SENTINEL_:
             utils.print_once("YF deprecation warning: set proxy via new config function: yf.set_proxy(proxy)")
             self._data._set_proxy(proxy)
@@ -56,7 +59,6 @@ def __init__(self, query, max_results=8, news_count=8, lists_count=8, include_cb
         self.max_results = max_results
         self.enable_fuzzy_query = enable_fuzzy_query
         self.news_count = news_count
-        self.session = session
         self.timeout = timeout
         self.raise_errors = raise_errors
 
@@ -67,7 +69,6 @@ def __init__(self, query, max_results=8, news_count=8, lists_count=8, include_cb
         self.enable_cultural_assets = include_cultural_assets
         self.recommended = recommended
 
-        self._data = YfData(session=self.session)
         self._logger = utils.get_yf_logger()
 
         self._response = {}