Skip to content

Commit 235f3b9

Browse files
committed
scripts: fix signing for electron-builder 26.8.0
We're poking into their internals to get the path of `signtool` on Windows; their implementation changed, so we need to update it. Signed-off-by: Mark Yen <mark.yen@suse.com>
1 parent 91f35a9 commit 235f3b9

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/actions/spelling/expect.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -639,6 +639,7 @@ tmutil
639639
toggleable
640640
togglefullscreen
641641
tonistiigi
642+
toolsets
642643
topmenu
643644
TQF
644645
traefik

scripts/lib/sign-win32.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import fs from 'fs';
66
import path from 'path';
77

8-
import { getSignVendorPath } from 'app-builder-lib/out/codeSign/windowsSignToolManager';
8+
import { getSignToolPath } from 'app-builder-lib/out/toolsets/windows';
99
import defaults from 'lodash/defaultsDeep';
1010
import merge from 'lodash/merge';
1111
import yaml from 'yaml';
@@ -73,7 +73,7 @@ export async function sign(workDir: string): Promise<string[]> {
7373
merge(config.win, REQUIRED_WINDOWS_CONFIG);
7474
config.win.certificateSha1 = certFingerprint;
7575

76-
const toolPath = path.join(await getSignVendorPath(), 'windows-10', process.arch, 'signtool.exe');
76+
const { path: toolPath } = await getSignToolPath(null, true);
7777
const toolArgs = [
7878
'sign',
7979
'/debug',

0 commit comments

Comments
 (0)