Merge pull request #9906 from rancher-sandbox/dependabot/npm_and_yarn/eslint/js-10.0.1

build(deps-dev): bump @eslint/js from 9.39.2 to 10.0.1

Author: jandubois

background.ts

@@ -368,7 +368,7 @@ function updateBackendLockState(backendIsLocked: string, action?: string): void
  * status.
  */
 async function doesBackendLockExist(): Promise<boolean> {
-  let backendIsLocked = '';
+  let backendIsLocked: string;
 
   const lockFileContents = await readBackendLockFile();
 

e2e/backend.e2e.spec.ts

@@ -86,8 +86,8 @@ test.describe.serial('KubernetesBackend', () => {
 
       try {
         return JSON.parse(text);
-      } catch (ex) {
-        throw new Error(`Response text is not JSON: \n${ text }`);
+      } catch (cause) {
+        throw new Error(`Response text is not JSON: \n${ text }`, { cause });
       }
     }
 

e2e/utils/ProfileUtils.ts

@@ -124,8 +124,8 @@ export async function verifyNoRegistrySubtree(hive: string): Promise<void> {
     }
     try {
       await childProcess.spawnFile('reg', ['delete', registryPath, '/f'], { stdio: ['ignore', 'pipe', 'pipe'] });
-    } catch (ex: any) {
-      throw new Error(`Need to remove registry hive "${ registryPath }" (tried, got error ${ ex }`);
+    } catch (cause: any) {
+      throw new Error(`Need to remove registry hive "${ registryPath }" (tried, got error ${ cause })`, { cause });
     }
   }
 }

e2e/utils/TestUtils.ts

@@ -72,9 +72,9 @@ async function setWindowsUserLegacyProfile(userProfile: RecursivePartial<Setting
         const keyPath = `HKCU\\SOFTWARE\\Rancher Desktop\\Profile\\${ registryType }`;
 
         await childProcess.spawnFile('reg.exe', ['DELETE', keyPath, '/f'], { stdio: 'pipe' });
-      } catch (ex: any) {
-        if (!/unable to find/.test(Object(ex).stderr ?? '')) {
-          throw new Error(`Error trying to delete a user registry hive: ${ ex }`);
+      } catch (cause: any) {
+        if (!/unable to find/.test(Object(cause).stderr ?? '')) {
+          throw new Error(`Error trying to delete a user registry hive: ${ cause }`, { cause });
         }
       }
 
@@ -86,8 +86,8 @@ async function setWindowsUserLegacyProfile(userProfile: RecursivePartial<Setting
         try {
           await fs.promises.writeFile(regFile, genResult);
           await childProcess.spawnFile('reg.exe', ['IMPORT', regFile], { stdio: 'ignore' });
-        } catch (ex: any) {
-          throw new Error(`Error trying to create a user registry hive: ${ ex }`);
+        } catch (cause: any) {
+          throw new Error(`Error trying to create a user registry hive: ${ cause }`, { cause });
         }
       }
     }
@@ -208,7 +208,7 @@ export async function teardownApp(app: ElectronApplication) {
       // Send SIGTERM to the process group, wait three seconds, then send
       // SIGKILL and wait for one more second.
       for (const [signal, timeout] of [['TERM', 3_000], ['KILL', 1_000]] as const) {
-        let pids: string[] = [];
+        let pids: string[];
 
         try {
           const args = ['-o', 'pid=', process.platform === 'darwin' ? '-g' : '--sid', `${ pid }`];

eslint.config.mts

@@ -89,6 +89,12 @@ export default defineConfigWithVueTs(
       sourceType: 'module',
     },
   },
+  {
+    // The `no-useless-assignment` rule is catching `export const getters = ...` for some reason.
+    name:  'rancher-desktop-useless-assignment-in-store',
+    files: ['pkg/rancher-desktop/store/*.ts'],
+    rules: { 'no-useless-assignment': 'off' },
+  },
   {
     // Disable TypeScript-specific rules in JavaScript files.
     name:  'rancher-desktop-js',
@@ -120,6 +126,18 @@ export default defineConfigWithVueTs(
       globals: globals.browser,
     },
   },
+  {
+    // Files we imported from Rancher Dashboard.
+    name:  'rancher-dashboard-useless-assignments',
+    files: [
+      'pkg/rancher-desktop/components/SortableTable/*',
+      'pkg/rancher-desktop/store/*.js',
+      'pkg/rancher-desktop/utils/*.js',
+    ],
+    rules: {
+      'no-useless-assignment': 'off',
+    },
+  },
   {
     // Compatibility: disable lints during the ESLint transition.
     name:    'rancher-desktop-compatibility',

package.json

@@ -102,7 +102,7 @@
     "@electron/fuses": "^2.0.0",
     "@electron/notarize": "3.1.1",
     "@eslint/compat": "2.0.2",
-    "@eslint/js": "9.39.2",
+    "@eslint/js": "10.0.1",
     "@playwright/test": "1.58.2",
     "@types/cross-spawn": "6.0.6",
     "@types/dompurify": "3.2.0",

pkg/rancher-desktop/backend/containerClient/auth.ts

@@ -61,7 +61,7 @@ class RegistryAuth {
       }
     }
 
-    let knownAuths: Record<string, { Username: string, Secret: string }> = {};
+    let knownAuths: Record<string, { Username: string, Secret: string }>;
 
     try {
       knownAuths = JSON.parse(await runCredentialCommand('list'));

pkg/rancher-desktop/config/commandLineOptions.ts

@@ -108,8 +108,8 @@ export function updateFromCommandLine(cfg: Settings, lockedFields: LockedSetting
     if (['boolean', 'number'].includes(currentValueType)) {
       try {
         finalValue = JSON.parse(finalValue);
-      } catch (err) {
-        throw new Error(`Can't evaluate --${ fqFieldName }=${ finalValue } as ${ currentValueType }: ${ err }`);
+      } catch (cause) {
+        throw new Error(`Can't evaluate --${ fqFieldName }=${ finalValue } as ${ currentValueType }: ${ cause }`, { cause });
       }
       // We know the current value's type is either boolean or number, so a constrained comparison is ok
       // eslint-disable-next-line valid-typeof

pkg/rancher-desktop/integrations/unixIntegrationManager.ts

@@ -213,7 +213,7 @@ export default class UnixIntegrationManager implements IntegrationManager {
 // a) is a symlink
 // b) has a target path of srcPath
 export async function ensureSymlink(srcPath: string, dstPath: string): Promise<void> {
-  let linkedTo = '';
+  let linkedTo: string;
 
   try {
     linkedTo = await fs.promises.readlink(dstPath);

pkg/rancher-desktop/integrations/windowsIntegrationManager.ts

@@ -530,15 +530,15 @@ export default class WindowsIntegrationManager implements IntegrationManager {
       const wslHelper = await this.getLinuxToolPath(distro, executable('wsl-helper-linux'));
 
       await this.execCommand({ distro }, wslHelper, 'kubeconfig', '--verify');
-    } catch (err: any) {
+    } catch (cause: any) {
       // Only throw for a specific error code 1, since we control that from the
       // kubeconfig --verify command. The logic here is to bubble up this error
       // so that the diagnostic is very specific to this issue. Any other errors
       // are captured as log messages.
-      if (err && 'code' in err && err.code === 1) {
-        throw new Error(`The kubeConfig contains non-Rancher Desktop configuration in distro ${ distro }`);
+      if (cause && 'code' in cause && cause.code === 1) {
+        throw new Error(`The kubeConfig contains non-Rancher Desktop configuration in distro ${ distro }`, { cause });
       } else {
-        console.error(`Verifying kubeconfig in distro ${ distro } failed: ${ err }`);
+        console.error(`Verifying kubeconfig in distro ${ distro } failed: ${ cause }`);
       }
     }
     console.debug(`Verified kubeconfig in the following distro: ${ distro }`);