Commit 8f45eb9
committed
fix(containers): address review feedback on Stats tab
- I1: cancel child process on timeout using AbortController; guard polls
with inFlight flag so concurrent calls cannot stack up
- I2: clean up session when renderer WebContents is destroyed (handles
hard reloads / crashes that bypass onBeforeUnmount)
- I3: emit container-stats/stopped to renderer before clearing sessions
in stopAll so the tab does not freeze on last sample after engine change
- I4: call resetBuffers on every isContainerRunning transition so prior-run
samples do not bleed into a new container lifecycle
- I5: gate Stats tab on Moby engine; show informational banner otherwise
- S1: divide NetIO / BlockIO deltas by refreshSeconds to plot bytes/s rate
- S2: waitForCharts also waits for a process-table row (proves data arrived)
- S3: replace whitespace-split tokenizer with column-position parser so
multi-word header fields (e.g. START TIME) are handled correctly
- S4: parsePair is explicit when no separator is present
- S5: reset prevNet*/prevBlock* in restartPolling to avoid spike on rate change
- S6: log non-JSON docker stats output instead of silently discarding it
- S7: track memory limit as a second dashed dataset for context
- S8: use exact version pins for chart.js and vue-chartjs (match project convention)
- S10: read chart palette from CSS custom properties with hardcoded fallbacks
- S11: make process-table and refresh-select e2e tests navigate independently
- S12: extract sendToFrame into shared main/ipcUtils.ts; use in both
containerStats.ts and containerExec.ts
Signed-off-by: Gildas Le Nadan <3ntr0p13+github@gmail.com>1 parent 4a2a9b7 commit 8f45eb9
9 files changed
Lines changed: 215 additions & 113 deletions
File tree
- e2e
- pages
- pkg/rancher-desktop
- components
- main
- typings
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
605 | 605 | | |
606 | 606 | | |
607 | 607 | | |
608 | | - | |
| 608 | + | |
609 | 609 | | |
610 | 610 | | |
611 | 611 | | |
612 | 612 | | |
613 | | - | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
614 | 616 | | |
615 | 617 | | |
616 | 618 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
37 | 39 | | |
38 | 40 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
0 commit comments